Skip to content

fix(linter): consistent-function-scoping false positive with hoisted var declarations #12523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 27, 2025
Merged

fix(linter): consistent-function-scoping false positive with hoisted var declarations #12523

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions crates/oxc_linter/src/rules/unicorn/consistent_function_scoping.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,13 @@ impl Rule for ConsistentFunctionScoping {
}

fn run<'a>(&self, node: &AstNode<'a>, ctx: &LintContext<'a>) {
let (function_declaration_symbol_id, function_name, function_body, reporter_span) =
let (
function_declaration_symbol_id,
function_name,
function_body,
reporter_span,
function_scope_id,
) =
match node.kind() {
AstKind::Function(function) => {
if function.is_typescript_syntax() {
Expand Down Expand Up @@ -215,13 +221,15 @@ impl Rule for ConsistentFunctionScoping {
Span::sized(function.span.start, 8),
|func_binding_ident| func_binding_ident.span,
),
func_scope_id,
)
} else if let Some(function_id) = &function.id {
(
function_id.symbol_id(),
Some(function_id.name),
function_body,
function_id.span(),
func_scope_id,
)
} else {
return;
Expand All @@ -237,6 +245,7 @@ impl Rule for ConsistentFunctionScoping {
Some(binding_ident.name),
&arrow_function.body,
binding_ident.span(),
arrow_function.scope_id(),
)
}
_ => return,
Expand Down Expand Up @@ -273,10 +282,8 @@ impl Rule for ConsistentFunctionScoping {
}

let parent_scope_ids = {
let mut current_scope_id =
ctx.scoping().symbol_scope_id(function_declaration_symbol_id);
let mut current_scope_id = function_scope_id;
let mut parent_scope_ids = FxHashSet::default();
parent_scope_ids.insert(current_scope_id);
while let Some(parent_scope_id) = ctx.scoping().scope_parent_id(current_scope_id) {
parent_scope_ids.insert(parent_scope_id);
current_scope_id = parent_scope_id;
Expand Down Expand Up @@ -749,6 +756,7 @@ fn test() {
",
None,
),
("function outer() { { let x; var inner = () => x; } return inner; }", None),
];

let fail = vec![
Expand Down
Loading