fix(ast): correct logic in Expression::is_call_like_expression
#12534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Dunqing
changed the title
Expression::is_call_like_expression
CodSpeed Instrumentation Performance ReportMerging #12534 will not alter performanceComparing Summary
Footnotes |
Member
Merge activity
|
) The `is_call_like_expression` function is intended to identify expressions that are function calls, new expressions, or import expressions. The previous implementation incorrectly used a logical AND (`&&`) to combine these checks. This would always evaluate to false, since an expression cannot be a `CallExpression` *and* a `NewExpression` or `ImportExpression` simultaneously. This pull request corrects the logic by replacing the logical AND (`&&`) with a logical OR (`||`). This ensures the function accurately returns `true` if an expression is any of the call-like types, aligning with its intended purpose.
graphite-app
bot
force-pushed
the
fix/is-call-like-expression
branch
from
7b0aef2 to
94b06ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
is_call_like_expressionfunction is intended to identify expressions that are function calls, new expressions, or import expressions. The previous implementation incorrectly used a logical AND (&&) to combine these checks. This would always evaluate to false, since an expression cannot be aCallExpressionand aNewExpressionorImportExpressionsimultaneously.This pull request corrects the logic by replacing the logical AND (
&&) with a logical OR (||). This ensures the function accurately returnstrueif an expression is any of the call-like types, aligning with its intended purpose.