fix(transformer/styled-components): preserve whitespace before interpolations in minification #12558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-transformer
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Dunqing
force-pushed
the
07-28-fix_transformer_preserve_whitespace_before_interpolations_in_styled-components_minification
branch
from
2aedf1f to
338b9c6
Compare
Dunqing
changed the title
CodSpeed Instrumentation Performance ReportMerging #12558 will not alter performanceComparing Summary
|
Dunqing
changed the title
Member
Merge activity
|
…olations in minification (#12558) close: #12556 Fixed an issue where spaces before template literal interpolations were incorrectly removed during CSS minification in the styled-components plugin. The fix ensures spaces are preserved (e.g., `padding: 0 ${PADDING}px` stays as `padding:0 ${PADDING}px` instead of becoming `padding:0${PADDING}px`).
graphite-app
bot
force-pushed
the
07-28-fix_transformer_preserve_whitespace_before_interpolations_in_styled-components_minification
branch
from
338b9c6 to
2f66dd2
Compare
graphite-app
bot
deleted the
07-28-fix_transformer_preserve_whitespace_before_interpolations_in_styled-components_minification
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close: #12556
Fixed an issue where spaces before template literal interpolations were incorrectly removed during CSS minification in the styled-components plugin.
The fix ensures spaces are preserved (e.g.,
padding: 0 ${PADDING}pxstays aspadding:0 ${PADDING}pxinstead of becomingpadding:0${PADDING}px).