Skip to content

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented Jul 28, 2025

Do not remove empty function calls if the function is async or generator or args can cause type error.

From test262:

function fn({}) {}

assert.throws(TypeError, function() {
  fn(null);
});

@graphite-app
Copy link
Contributor

graphite-app bot commented Jul 28, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-minifier Area - Minifier C-bug Category - Bug labels Jul 28, 2025
@Boshen Boshen force-pushed the 07-28-fix_tasks_coverage_fix_test262_runtime_errors branch 2 times, most recently from 4b7d7c3 to ef87dd0 Compare July 28, 2025 12:31
@codspeed-hq
Copy link

codspeed-hq bot commented Jul 28, 2025

CodSpeed Instrumentation Performance Report

Merging #12573 will not alter performance

Comparing 07-28-fix_tasks_coverage_fix_test262_runtime_errors (fe9c8e1) with main (7af38e1)1

Summary

✅ 34 untouched benchmarks

Footnotes

  1. No successful run was found on main (3ba360e) during the generation of this report, so 7af38e1 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Jul 28, 2025
Copy link
Member Author

Boshen commented Jul 28, 2025

Merge activity

Do not remove empty function calls if the function is async or generator or args can cause type error.

From test262:

```js
function fn({}) {}

assert.throws(TypeError, function() {
  fn(null);
});
```
@graphite-app graphite-app bot force-pushed the 07-28-fix_tasks_coverage_fix_test262_runtime_errors branch from ef87dd0 to fe9c8e1 Compare July 28, 2025 12:54
@graphite-app graphite-app bot merged commit fe9c8e1 into main Jul 28, 2025
24 checks passed
@graphite-app graphite-app bot deleted the 07-28-fix_tasks_coverage_fix_test262_runtime_errors branch July 28, 2025 13:02
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jul 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-minifier Area - Minifier C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants