Skip to content

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Aug 4, 2025

type k = import ('foo').bar

@Dunqing previously, the bar reference would have ReferenceFlags::read, but since it's only used as a type i think it should only have the type reference flags?

fixes #12693

Copy link
Contributor Author

camc314 commented Aug 4, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-linter Area - Linter A-semantic Area - Semantic C-bug Category - Bug labels Aug 4, 2025
@camc314 camc314 marked this pull request as ready for review August 4, 2025 09:22
@camc314 camc314 requested a review from Dunqing as a code owner August 4, 2025 09:22
@codspeed-hq
Copy link

codspeed-hq bot commented Aug 4, 2025

CodSpeed Instrumentation Performance Report

Merging #12797 will not alter performance

Comparing c/08-04-fix_semantic_fix_reference_type_flags_when_visiting_tsimporttype_ (c5cfc27) with main (5475075)

Summary

✅ 34 untouched benchmarks

@Dunqing
Copy link
Member

Dunqing commented Aug 4, 2025

The root cause is due to the qualifier of TSImportType includes an unexpected IdentifierReference , see #12042. If this can solve your problem, I am happy to go with it. Additionally, could you please add a comment to link that issue to the change?

@camc314 camc314 force-pushed the c/08-04-fix_semantic_fix_reference_type_flags_when_visiting_tsimporttype_ branch from 153e032 to c5cfc27 Compare August 4, 2025 09:37
@camc314
Copy link
Contributor Author

camc314 commented Aug 4, 2025

The root cause is due to the qualifier of TSImportType includes an unexpected IdentifierReference , see #12042.

Ah i see, I think it would be better to change the ast and fix it there?

@Dunqing
Copy link
Member

Dunqing commented Aug 4, 2025

Ah i see, I think it would be better to change the ast and fix it there?

Yeah, but I guess there is a lot of work to change this, so this is the reason why Boshen gives up, I guess.

@camc314
Copy link
Contributor Author

camc314 commented Aug 4, 2025

fixed by #12799

@camc314 camc314 closed this Aug 4, 2025
graphite-app bot pushed a commit that referenced this pull request Aug 4, 2025
graphite-app bot pushed a commit that referenced this pull request Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter A-semantic Area - Semantic C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

linter: eslint(no-undef) false positive

3 participants