-
-
Notifications
You must be signed in to change notification settings - Fork 726
fix(minifier): do not remove using x =
#13052
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a bug in the minifier where using and await using declarations were being incorrectly removed as unused. The fix prevents the removal of these declarations because their usage through Symbol.dispose cannot be statically determined.
- Added a safety check to prevent removal of
usingdeclarations - Implemented a new
is_using()helper method to identify using declarations - Added test coverage for both
usingandawait usingscenarios
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| crates/oxc_minifier/src/peephole/remove_unused_declaration.rs | Added safety check to prevent removal of using declarations and corresponding tests |
| crates/oxc_ast/src/ast_impl/js.rs | Added is_using() helper method to identify using declarations |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Merge activity
|
CodSpeed Instrumentation Performance ReportMerging #13052 will not alter performanceComparing Summary
|
a183a93 to
6686cc4
Compare

fixes #13050