Skip to content

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Aug 13, 2025

Tiny refactor. Just to clarify when a var contains an Allocator, and when an AllocatorGuard.

@github-actions github-actions bot added A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Aug 13, 2025
Copy link
Member Author

overlookmotel commented Aug 13, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Aug 13, 2025

CodSpeed Instrumentation Performance Report

Merging #13073 will not alter performance

Comparing 08-13-refactor_linter_dereference_allocator_from_allocatorguard_ (5783df2) with main (1c15288)1

Summary

✅ 34 untouched benchmarks

Footnotes

  1. No successful run was found on main (5783df2) during the generation of this report, so 1c15288 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Aug 14, 2025
Copy link
Contributor

camc314 commented Aug 14, 2025

Merge activity

@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Aug 14, 2025
@overlookmotel overlookmotel force-pushed the 08-13-refactor_linter_dereference_allocator_from_allocatorguard_ branch from 93e140c to dbbd9c9 Compare August 14, 2025 20:09
@overlookmotel overlookmotel force-pushed the 08-13-refactor_linter_avoid_unnecessary_var_initialization branch from 5693ef3 to 537d2dd Compare August 14, 2025 20:09
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Aug 14, 2025
Tiny refactor. Just to clarify when a var contains an `Allocator`, and when an `AllocatorGuard`.
@graphite-app graphite-app bot force-pushed the 08-13-refactor_linter_avoid_unnecessary_var_initialization branch from 537d2dd to 1d77d92 Compare August 14, 2025 20:53
@graphite-app graphite-app bot force-pushed the 08-13-refactor_linter_dereference_allocator_from_allocatorguard_ branch from dbbd9c9 to 5783df2 Compare August 14, 2025 20:53
Base automatically changed from 08-13-refactor_linter_avoid_unnecessary_var_initialization to main August 14, 2025 20:57
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Aug 14, 2025
@graphite-app graphite-app bot merged commit 5783df2 into main Aug 14, 2025
26 checks passed
@graphite-app graphite-app bot deleted the 08-13-refactor_linter_dereference_allocator_from_allocatorguard_ branch August 14, 2025 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants