Skip to content

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented Aug 14, 2025

No description provided.

Copilot AI review requested due to automatic review settings August 14, 2025 06:00
@github-actions github-actions bot added A-minifier Area - Minifier C-performance Category - Solution not expected to change functional behavior, only performance labels Aug 14, 2025
Copy link
Member Author

Boshen commented Aug 14, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR optimizes the minifier by avoiding unnecessary reference collection when the AST remains unchanged during optimization passes.

  • Conditional reference collection to improve performance when no changes are made
  • Early assignment of changed state to enable conditional logic

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codspeed-hq
Copy link

codspeed-hq bot commented Aug 14, 2025

CodSpeed Instrumentation Performance Report

Merging #13078 will improve performances by 15.36%

Comparing 08-14-perf_minifier_no_need_to_collect_references_if_ast_is_not_changed (ac2ccd0) with main (1385c71)1

Summary

⚡ 4 improvements
✅ 30 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
minifier[RadixUIAdoptionSection.jsx] 64.6 µs 58.6 µs +10.28%
minifier[binder.ts] 4.2 ms 3.6 ms +15.36%
minifier[cal.com.tsx] 32.8 ms 29.8 ms +10.3%
minifier[react.development.js] 2.3 ms 2.1 ms +8.28%

Footnotes

  1. No successful run was found on main (4f2cc96) during the generation of this report, so 1385c71 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@Boshen Boshen merged commit 2625bdf into main Aug 14, 2025
26 checks passed
@Boshen Boshen deleted the 08-14-perf_minifier_no_need_to_collect_references_if_ast_is_not_changed branch August 14, 2025 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-minifier Area - Minifier C-performance Category - Solution not expected to change functional behavior, only performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants