Skip to content

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Aug 14, 2025

fixes #13065

@github-actions github-actions bot added A-linter Area - Linter C-bug Category - Bug labels Aug 14, 2025
Copy link
Contributor Author

camc314 commented Aug 14, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camc314 camc314 marked this pull request as ready for review August 14, 2025 16:15
Copilot AI review requested due to automatic review settings August 14, 2025 16:15
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the default configuration for the no-this-alias TypeScript linter rule to match ESLint's default behavior, where destructuring is allowed by default.

  • Removed Default derive trait from NoThisAliasConfig and implemented it manually
  • Changed default value for allowDestructuring from false to true in configuration parsing

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

@graphite-app
Copy link
Contributor

graphite-app bot commented Aug 14, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the c/08-14-fix_linter_no-this-alias_update_nothisaliasconfig_default_config branch from a354c84 to f97791a Compare August 14, 2025 16:18
@codspeed-hq
Copy link

codspeed-hq bot commented Aug 14, 2025

CodSpeed Instrumentation Performance Report

Merging #13095 will not alter performance

Comparing c/08-14-fix_linter_no-this-alias_update_nothisaliasconfig_default_config (f97791a) with main (43b1c5a)1

Summary

✅ 34 untouched benchmarks

Footnotes

  1. No successful run was found on main (f97791a) during the generation of this report, so 43b1c5a was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@graphite-app graphite-app bot merged commit f97791a into main Aug 14, 2025
25 checks passed
@graphite-app graphite-app bot deleted the c/08-14-fix_linter_no-this-alias_update_nothisaliasconfig_default_config branch August 14, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(linter): Incorrect defaults for typsescript/no-this-alias

2 participants