-
-
Notifications
You must be signed in to change notification settings - Fork 724
fix(linter/no-this-alias): update NoThisAliasConfig default config #13095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(linter/no-this-alias): update NoThisAliasConfig default config #13095
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes the default configuration for the no-this-alias TypeScript linter rule to match ESLint's default behavior, where destructuring is allowed by default.
- Removed
Defaultderive trait fromNoThisAliasConfigand implemented it manually - Changed default value for
allowDestructuringfromfalsetotruein configuration parsing
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
Merge activity
|
a354c84 to
f97791a
Compare
CodSpeed Instrumentation Performance ReportMerging #13095 will not alter performanceComparing Summary
Footnotes |

fixes #13065