Skip to content

refactor(ast): shorten serialize code using let chains #13100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 14, 2025
Merged

refactor(ast): shorten serialize code using let chains #13100

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 11 additions & 13 deletions crates/oxc_ast/src/serialize/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,27 +193,25 @@ fn get_ts_start_span(program: &Program<'_>) -> u32 {
return program.span.end;
};

let start = first_stmt.span().start;
match first_stmt {
Statement::ExportNamedDeclaration(decl) => {
let start = decl.span.start;
if let Some(Declaration::ClassDeclaration(class)) = &decl.declaration {
if let Some(decorator) = class.decorators.first() {
return cmp::min(start, decorator.span.start);
}
if let Some(Declaration::ClassDeclaration(class)) = &decl.declaration
&& let Some(decorator) = class.decorators.first()
{
return cmp::min(start, decorator.span.start);
}
start
}
Statement::ExportDefaultDeclaration(decl) => {
let start = decl.span.start;
if let ExportDefaultDeclarationKind::ClassDeclaration(class) = &decl.declaration {
if let Some(decorator) = class.decorators.first() {
return cmp::min(start, decorator.span.start);
}
if let ExportDefaultDeclarationKind::ClassDeclaration(class) = &decl.declaration
&& let Some(decorator) = class.decorators.first()
{
return cmp::min(start, decorator.span.start);
}
start
}
_ => first_stmt.span().start,
_ => {}
}
start
}

/// Serialize `value` field of `Comment`.
Expand Down
Loading