Skip to content

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Aug 18, 2025

fixes #13167

@github-actions github-actions bot added A-linter Area - Linter C-bug Category - Bug labels Aug 18, 2025
@camc314 camc314 marked this pull request as ready for review August 18, 2025 13:59
Copilot AI review requested due to automatic review settings August 18, 2025 13:59
Copy link
Contributor Author

camc314 commented Aug 18, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Aug 18, 2025

CodSpeed Instrumentation Performance Report

Merging #13189 will not alter performance

Comparing c/08-18-fix_linter_prefer-await-to-then_false_positive_with_promise_call_as_return_arg (ada4e84) with main (c138fad)1

Summary

✅ 34 untouched benchmarks

Footnotes

  1. No successful run was found on main (ada4e84) during the generation of this report, so c138fad was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@graphite-app
Copy link
Contributor

graphite-app bot commented Aug 18, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the c/08-18-fix_linter_prefer-await-to-then_false_positive_with_promise_call_as_return_arg branch from 9683e0c to ada4e84 Compare August 18, 2025 22:25
@graphite-app graphite-app bot merged commit ada4e84 into main Aug 18, 2025
24 checks passed
@graphite-app graphite-app bot deleted the c/08-18-fix_linter_prefer-await-to-then_false_positive_with_promise_call_as_return_arg branch August 18, 2025 22:29
This was referenced Aug 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

linter: promise/catch-or-return warning when result is returned

2 participants