fix(language_server): split run logic for oxlint and tsgolint
#13332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
A-editor
CodSpeed Instrumentation Performance ReportMerging #13332 will not alter performanceComparing Summary
Footnotes |
Sysix
force-pushed
the
08-27-fix_language_server_split_run_logic_for_oxlint_and_tsgolint_
branch
2 times, most recently
from
35fcbd7 to
502f748
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Sysix
force-pushed
the
08-27-fix_language_server_split_run_logic_for_oxlint_and_tsgolint_
branch
from
502f748 to
8add59c
Compare
camc314
approved these changes
Aug 27, 2025
Contributor
Merge activity
|
graphite-app
bot
force-pushed
the
08-27-fix_language_server_split_run_logic_for_oxlint_and_tsgolint_
branch
from
8add59c to
902b39b
Compare
graphite-app
bot
deleted the
08-27-fix_language_server_split_run_logic_for_oxlint_and_tsgolint_
branch
camc314
pushed a commit
that referenced
this pull request
Sep 11, 2025
…e` is disabled and run is onType (#13604) Fixes an edge case introduced in #13332 where diagnostics disappear when saving a file with `oxc.lint.run: "onType"` and `oxc.typeAware: false`. ## Problem The logic from #13332 assumes `tsgolint` always exists when `Run::OnType`: ```rust (ServerLinterRun::OnSave, Run::OnType) => (false, true) // always run tsgolint ``` But when `type_aware: false`, there is no `tsgo_linter`, causing the server to return empty diagnostics instead of None, which clears all error highlights in VSCode.  ## Solution Check if `tsgo_linter` actually exists: ```rust (ServerLinterRun::OnSave, Run::OnType) => { let should_run_tsgo = self.tsgo_linter.as_ref().is_some(); (false, should_run_tsgo) } ``` Now returns None when no linters should run, preserving existing diagnostics. **Test:** Added `test_lint_on_run_on_type_on_save_without_type_aware` with fixture
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the user configuration
onType(default) is respected even whentypeAwareis enabled.tsoglintwill then lintonSave, even whenonTypeis set.