Skip to content

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Aug 27, 2025

Refactor linter benchmark so it parses and generates Semantic afresh before each measured iteration.

This is more realistic usage - in real world you'd never lint the same file repeatedly - and may make cache utilization in the benchmark more realistic.

It also prepares the way for upcoming changes where ContextSubHost::new will take an owned Semantic instead of Rc<Semantic>.

Copy link
Member Author

overlookmotel commented Aug 27, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Aug 27, 2025
@overlookmotel overlookmotel marked this pull request as ready for review August 27, 2025 18:24
@codspeed-hq
Copy link

codspeed-hq bot commented Aug 27, 2025

CodSpeed Instrumentation Performance Report

Merging #13335 will not alter performance

Comparing 08-27-refactor_benchmarks_linter_benchmark_re-run_parsing_and_semantic_on_each_iteration (7fdd478) with main (827fe1c)1

Summary

✅ 34 untouched benchmarks

Footnotes

  1. No successful run was found on main (7fdd478) during the generation of this report, so 827fe1c was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Aug 27, 2025
Copy link
Contributor

camc314 commented Aug 27, 2025

Merge activity

… each iteration (#13335)

Refactor linter benchmark so it parses and generates `Semantic` afresh before each measured iteration.

This is more realistic usage - in real world you'd never lint the same file repeatedly - and may make cache utilization in the benchmark more realistic.

It also prepares the way for upcoming changes where `ContextSubHost::new` will take an owned `Semantic` instead of `Rc<Semantic>`.
@graphite-app graphite-app bot force-pushed the 08-27-refactor_benchmarks_linter_benchmark_re-run_parsing_and_semantic_on_each_iteration branch from 5574085 to 7fdd478 Compare August 27, 2025 21:42
@graphite-app graphite-app bot merged commit 7fdd478 into main Aug 27, 2025
24 checks passed
@graphite-app graphite-app bot deleted the 08-27-refactor_benchmarks_linter_benchmark_re-run_parsing_and_semantic_on_each_iteration branch August 27, 2025 21:47
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Aug 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants