fix(transformer/styled-components): remove more escaped line breaks in CSS minification #13380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
A-transformer
CodSpeed Instrumentation Performance ReportMerging #13380 will not alter performanceComparing Summary
Footnotes |
overlookmotel
force-pushed
the
08-29-fix_transformer_styled-components_remove_unnecessary_whitespace_around_block_comments_in_css_minification
branch
from
fe2e345 to
dd95896
Compare
overlookmotel
force-pushed
the
08-29-fix_transformer_styled-components_remove_more_escaped_line_breaks_in_css_minification
branch
from
17636b0 to
0a54e8a
Compare
Member
Merge activity
|
graphite-app
bot
force-pushed
the
08-29-fix_transformer_styled-components_remove_unnecessary_whitespace_around_block_comments_in_css_minification
branch
from
dd95896 to
1cf9b20
Compare
graphite-app bot
pushed a commit
that referenced
this pull request
Aug 29, 2025
…n CSS minification (#13380) The change in approach to whitespace in #13379 means we can remove more escaped line breaks (`\r` and `\n`). Previously when processing `\r\n`, the next character after `\r` was seen as `\`, and therefore a space was unnecessarily inserted. Now we only look backwards, not forwards, so this problem goes away. We just treat `\r` and `\n` like any other whitespace.
graphite-app
bot
force-pushed
the
08-29-fix_transformer_styled-components_remove_more_escaped_line_breaks_in_css_minification
branch
from
0a54e8a to
7307483
Compare
…n CSS minification (#13380) The change in approach to whitespace in #13379 means we can remove more escaped line breaks (`\r` and `\n`). Previously when processing `\r\n`, the next character after `\r` was seen as `\`, and therefore a space was unnecessarily inserted. Now we only look backwards, not forwards, so this problem goes away. We just treat `\r` and `\n` like any other whitespace.
graphite-app
bot
force-pushed
the
08-29-fix_transformer_styled-components_remove_unnecessary_whitespace_around_block_comments_in_css_minification
branch
from
1cf9b20 to
6dc5b70
Compare
graphite-app
bot
force-pushed
the
08-29-fix_transformer_styled-components_remove_more_escaped_line_breaks_in_css_minification
branch
from
7307483 to
c900b3e
Compare
Base automatically changed from
08-29-fix_transformer_styled-components_remove_unnecessary_whitespace_around_block_comments_in_css_minification
to
main
August 29, 2025 05:31
graphite-app
bot
deleted the
08-29-fix_transformer_styled-components_remove_more_escaped_line_breaks_in_css_minification
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change in approach to whitespace in #13379 means we can remove more escaped line breaks (
\rand\n).Previously when processing
\r\n, the next character after\rwas seen as\, and therefore a space was unnecessarily inserted.Now we only look backwards, not forwards, so this problem goes away. We just treat
\rand\nlike any other whitespace.