Skip to content

Conversation

@Sysix
Copy link
Member

@Sysix Sysix commented Sep 3, 2025

No description provided.

@github-actions github-actions bot added A-editor Area - Editor and Language Server C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Sep 3, 2025
Copy link
Member Author

Sysix commented Sep 3, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Sysix Sysix marked this pull request as ready for review September 3, 2025 20:50
Copilot AI review requested due to automatic review settings September 3, 2025 20:50
@Sysix Sysix requested a review from camc314 as a code owner September 3, 2025 20:50
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR configures the oxlint linting tool to include VSCode test files in linting while adding appropriate rule overrides for testing framework compatibility.

  • Removes VSCode test files from the ignored patterns list
  • Adds override configuration to disable vitest-specific rules for Mocha-based VSCode tests
  • Adds inline lint disable comments for legitimate no-await-in-loop usage in test helpers

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
oxlintrc.json Configures linting overrides for VSCode test files and removes them from ignore patterns
editors/vscode/tests/test-helpers.ts Adds inline lint disable comments for legitimate await-in-loop usage
Comments suppressed due to low confidence (1)

editors/vscode/tests/test-helpers.ts:1

  • [nitpick] The trailing empty line at the end of the file should be removed to maintain consistent file formatting.
import { Func } from 'mocha';

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Sep 4, 2025
Copy link
Contributor

camc314 commented Sep 4, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 09-03-chore_lint_don_t_ignore_vscode_test_files branch from da2a2d8 to 629cfae Compare September 4, 2025 07:46
@graphite-app graphite-app bot merged commit 629cfae into main Sep 4, 2025
17 checks passed
@graphite-app graphite-app bot deleted the 09-03-chore_lint_don_t_ignore_vscode_test_files branch September 4, 2025 07:51
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Sep 4, 2025
Copilot AI pushed a commit that referenced this pull request Sep 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-editor Area - Editor and Language Server C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants