Skip to content

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Sep 11, 2025

Utilize is_exhausted methods of NonEmptyStack and SparseStack (added in #13672) in transformer and oxc_estree to clarify what these checks are doing.

@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Sep 11, 2025
Copy link
Member Author

overlookmotel commented Sep 11, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Sep 11, 2025

CodSpeed Instrumentation Performance Report

Merging #13674 will not alter performance

Comparing 09-11-refactor_transformer_estree_clarify_code_using_is_exhausted_stack_methods (08cbd39) with main (e433633)1

Summary

✅ 37 untouched benchmarks

Footnotes

  1. No successful run was found on main (08cbd39) during the generation of this report, so e433633 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@overlookmotel overlookmotel marked this pull request as ready for review September 11, 2025 05:55
@overlookmotel overlookmotel force-pushed the 09-11-refactor_transformer_estree_clarify_code_using_is_exhausted_stack_methods branch from 9aa4d96 to a461bb1 Compare September 11, 2025 06:01
@overlookmotel overlookmotel force-pushed the 09-11-refactor_data_structures_make_nonemptystack_is_empty_a_compile-time_error branch from 71381d1 to 41f48d5 Compare September 11, 2025 06:01
@graphite-app graphite-app bot changed the base branch from 09-11-refactor_data_structures_make_nonemptystack_is_empty_a_compile-time_error to graphite-base/13674 September 11, 2025 06:07
@Dunqing Dunqing added the 0-merge Merge with Graphite Merge Queue label Sep 11, 2025
Copy link
Member

Dunqing commented Sep 11, 2025

Merge activity

@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Sep 11, 2025
@graphite-app graphite-app bot changed the base branch from graphite-base/13674 to main September 11, 2025 06:12
…k methods (#13674)

Utilize `is_exhausted` methods of `NonEmptyStack` and `SparseStack` (added in #13672) in transformer and `oxc_estree` to clarify what these checks are doing.
@graphite-app graphite-app bot force-pushed the 09-11-refactor_transformer_estree_clarify_code_using_is_exhausted_stack_methods branch from a461bb1 to 08cbd39 Compare September 11, 2025 06:13
@graphite-app graphite-app bot merged commit 08cbd39 into main Sep 11, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 09-11-refactor_transformer_estree_clarify_code_using_is_exhausted_stack_methods branch September 11, 2025 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants