Skip to content

Conversation

@Sysix
Copy link
Member

@Sysix Sysix commented Sep 13, 2025

tasks/coverage/typescript/tests/cases/conformance/types/uniqueSymbol/uniqueSymbols.ts

line 95:

interface I {
  readonly readonlyType: unique symbol;
}

would be formatted to:

interface I {
  readonlyreadonlyType: unique symbol
}

@github-actions github-actions bot added A-formatter Area - Formatter C-bug Category - Bug labels Sep 13, 2025
Copy link
Member Author

Sysix commented Sep 13, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Sep 13, 2025

CodSpeed Instrumentation Performance Report

Merging #13747 will not alter performance

Comparing 09-13-fix_formatter_add_space_after_readonly_in_tspropertysignature_ (0b48186) with main (56da114)1

Summary

✅ 37 untouched

Footnotes

  1. No successful run was found on main (0b48186) during the generation of this report, so 56da114 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@Sysix Sysix marked this pull request as ready for review September 13, 2025 19:06
@Sysix Sysix requested a review from Dunqing as a code owner September 13, 2025 19:06
Copilot AI review requested due to automatic review settings September 13, 2025 19:06
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a formatting issue in TypeScript property signatures where the readonly keyword was being concatenated with the property name without a space. The fix ensures proper spacing is maintained after the readonly keyword and removes redundant spacing for computed properties.

  • Adds a space after the readonly keyword in TSPropertySignature formatting
  • Removes redundant space before computed property brackets when readonly is present

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Dunqing Dunqing added the 0-merge Merge with Graphite Merge Queue label Sep 15, 2025
Copy link
Member

Dunqing commented Sep 15, 2025

Merge activity

…13747)

`tasks/coverage/typescript/tests/cases/conformance/types/uniqueSymbol/uniqueSymbols.ts`

line 95:

```
interface I {
  readonly readonlyType: unique symbol;
}
```

would be formatted to:

```
interface I {
  readonlyreadonlyType: unique symbol
}
```
@graphite-app graphite-app bot force-pushed the 09-13-fix_formatter_add_space_after_readonly_in_tspropertysignature_ branch from 50c3333 to 0b48186 Compare September 15, 2025 01:45
@graphite-app graphite-app bot merged commit 0b48186 into main Sep 15, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 09-13-fix_formatter_add_space_after_readonly_in_tspropertysignature_ branch September 15, 2025 01:51
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Sep 15, 2025
@Boshen Boshen mentioned this pull request Sep 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-formatter Area - Formatter C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants