Skip to content

fix(formatter): missing parenthesis for TSAsExpression #13842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 17, 2025
Merged

fix(formatter): missing parenthesis for TSAsExpression #13842

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 20 additions & 13 deletions crates/oxc_formatter/src/parentheses/expression.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -626,13 +626,13 @@ impl<'a> NeedsParentheses<'a> for AstNode<'a, JSXEmptyExpression> {

impl<'a> NeedsParentheses<'a> for AstNode<'a, TSAsExpression<'a>> {
fn needs_parentheses(&self, f: &Formatter<'_, 'a>) -> bool {
ts_as_or_satisfies_needs_parens(self.parent)
ts_as_or_satisfies_needs_parens(self.span(), &self.expression, self.parent)
}
}

impl<'a> NeedsParentheses<'a> for AstNode<'a, TSSatisfiesExpression<'a>> {
fn needs_parentheses(&self, f: &Formatter<'_, 'a>) -> bool {
ts_as_or_satisfies_needs_parens(self.parent)
ts_as_or_satisfies_needs_parens(self.span(), &self.expression, self.parent)
}
}

Expand All @@ -649,7 +649,7 @@ impl<'a> NeedsParentheses<'a> for AstNode<'a, TSTypeAssertion<'a>> {
}

fn type_cast_like_needs_parens(span: Span, parent: &AstNodes<'_>) -> bool {
#[expect(clippy::match_same_arms)]
#[expect(clippy::match_same_arms)] // for better readability
match parent {
AstNodes::ExportDefaultDeclaration(_)
| AstNodes::TSTypeAssertion(_)
Expand Down Expand Up @@ -942,16 +942,23 @@ fn await_or_yield_needs_parens(span: Span, node: &AstNodes<'_>) -> bool {
}
}

fn ts_as_or_satisfies_needs_parens(parent: &AstNodes<'_>) -> bool {
matches!(
parent,
AstNodes::ComputedMemberExpression(_)
| AstNodes::StaticMemberExpression(_)
| AstNodes::PrivateFieldExpression(_)
| AstNodes::AssignmentExpression(_)
| AstNodes::AssignmentTargetWithDefault(_)
| AstNodes::UpdateExpression(_)
)
fn ts_as_or_satisfies_needs_parens(
span: Span,
inner: &Expression<'_>,
parent: &AstNodes<'_>,
) -> bool {
match parent {
AstNodes::ConditionalExpression(_)
// Binary-like
| AstNodes::LogicalExpression(_)
| AstNodes::BinaryExpression(_) => true,
// `export default (function foo() {} as bar)` and `export default (class {} as bar)`
AstNodes::ExportDefaultDeclaration(_) =>
matches!(inner, Expression::FunctionExpression(_) | Expression::ClassExpression(_)),
_ => {
type_cast_like_needs_parens(span, parent)
}
}
}

fn is_class_extends(span: Span, parent: &AstNodes<'_>) -> bool {
Expand Down
4 changes: 1 addition & 3 deletions tasks/coverage/snapshots/formatter_misc.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
formatter_misc Summary:
AST Parsed : 49/49 (100.00%)
Positive Passed: 45/49 (91.84%)
Positive Passed: 46/49 (93.88%)
Expect to Parse: tasks/coverage/misc/pass/oxc-11487.cjs
Cannot use `await` as an identifier in an async context
Mismatch: tasks/coverage/misc/pass/oxc-12612.ts

Mismatch: tasks/coverage/misc/pass/oxc-2592.ts

Expect to Parse: tasks/coverage/misc/pass/oxc-4449.ts
Expand Down
30 changes: 5 additions & 25 deletions tasks/coverage/snapshots/formatter_typescript.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,41 +2,31 @@ commit: 261630d6

formatter_typescript Summary:
AST Parsed : 8816/8816 (100.00%)
Positive Passed: 8775/8816 (99.53%)
Positive Passed: 8785/8816 (99.65%)
Mismatch: tasks/coverage/typescript/tests/cases/compiler/amdLikeInputDeclarationEmit.ts

Expect to Parse: tasks/coverage/typescript/tests/cases/compiler/arrayFromAsync.ts
`await` is only allowed within async functions and at the top levels of modules`await` is only allowed within async functions and at the top levels of modules`await` is only allowed within async functions and at the top levels of modules`await` is only allowed within async functions and at the top levels of modules`await` is only allowed within async functions and at the top levels of modules`await` is only allowed within async functions and at the top levels of modules`await` is only allowed within async functions and at the top levels of modules`await` is only allowed within async functions and at the top levels of modules`await` is only allowed within async functions and at the top levels of modules`await` is only allowed within async functions and at the top levels of modules`await` is only allowed within async functions and at the top levels of modules
Mismatch: tasks/coverage/typescript/tests/cases/compiler/callOfConditionalTypeWithConcreteBranches.ts

Expect to Parse: tasks/coverage/typescript/tests/cases/compiler/castFunctionExpressionShouldBeParenthesized.ts
Expected a semicolon or an implicit semicolon after a statement, but found none
Mismatch: tasks/coverage/typescript/tests/cases/compiler/coAndContraVariantInferences3.ts

Mismatch: tasks/coverage/typescript/tests/cases/compiler/complexNarrowingWithAny.ts

Mismatch: tasks/coverage/typescript/tests/cases/compiler/declarationEmitCastReusesTypeNode4.ts

Expect to Parse: tasks/coverage/typescript/tests/cases/compiler/declarationEmitPromise.ts
Expected a semicolon or an implicit semicolon after a statement, but found none
Mismatch: tasks/coverage/typescript/tests/cases/compiler/declarationEmitRecursiveConditionalAliasPreserved.ts

Mismatch: tasks/coverage/typescript/tests/cases/compiler/declarationEmitShadowingInferNotRenamed.ts

Expect to Parse: tasks/coverage/typescript/tests/cases/compiler/exportDefaultParenthesizeES6.ts
Expected a semicolon or an implicit semicolon after a statement, but found none
Mismatch: tasks/coverage/typescript/tests/cases/compiler/jsxNamespaceGlobalReexport.tsx

Mismatch: tasks/coverage/typescript/tests/cases/compiler/jsxNamespaceGlobalReexportMissingAliasTarget.tsx

Mismatch: tasks/coverage/typescript/tests/cases/compiler/jsxNamespaceImplicitImportJSXNamespace.tsx

Expect to Parse: tasks/coverage/typescript/tests/cases/compiler/narrowingByTypeofInSwitch.ts
Expected a semicolon or an implicit semicolon after a statement, but found none
Mismatch: tasks/coverage/typescript/tests/cases/compiler/propertyAccessExpressionInnerComments.ts

Expect to Parse: tasks/coverage/typescript/tests/cases/compiler/readonlyAssignmentInSubclassOfClassExpression.ts
Expected `{` but found `as`
Expect to Parse: tasks/coverage/typescript/tests/cases/compiler/reverseMappedTypeInferenceSameSource1.ts
An implementation cannot be declared in ambient contexts.
Mismatch: tasks/coverage/typescript/tests/cases/compiler/sourceMapValidationClasses.ts
Expand All @@ -45,8 +35,6 @@ Mismatch: tasks/coverage/typescript/tests/cases/compiler/styledComponentsInstant

Mismatch: tasks/coverage/typescript/tests/cases/compiler/substitutionTypeForIndexedAccessType2.ts

Expect to Parse: tasks/coverage/typescript/tests/cases/compiler/superAccessCastedCall.ts
Expected a semicolon or an implicit semicolon after a statement, but found none
Mismatch: tasks/coverage/typescript/tests/cases/compiler/tryStatementInternalComments.ts

Mismatch: tasks/coverage/typescript/tests/cases/compiler/unionSignaturesWithThisParameter.ts
Expand All @@ -57,31 +45,23 @@ Expect to Parse: tasks/coverage/typescript/tests/cases/conformance/classes/prope
Classes may not have a static property named prototypeClasses may not have a static property named prototypeClasses may not have a static property named prototypeClasses may not have a static property named prototypeClasses may not have a static property named prototypeClasses may not have a static property named prototype
Expect to Parse: tasks/coverage/typescript/tests/cases/conformance/controlFlow/controlFlowAssignmentPatternOrder.ts
An implementation cannot be declared in ambient contexts.
Expect to Parse: tasks/coverage/typescript/tests/cases/conformance/esDecorators/classDeclaration/classSuper/esDecorators-classDeclaration-classSuper.2.ts
Expected `{` but found `as`
Expect to Parse: tasks/coverage/typescript/tests/cases/conformance/esDecorators/classExpression/classSuper/esDecorators-classExpression-classSuper.2.ts
Expected `{` but found `as`
Expect to Parse: tasks/coverage/typescript/tests/cases/conformance/esDecorators/classExpression/esDecorators-classExpression-missingEmitHelpers-classDecorator.3.ts
Decorators are not valid here.Unexpected token
Expect to Parse: tasks/coverage/typescript/tests/cases/conformance/esDecorators/classExpression/namedEvaluation/esDecorators-classExpression-namedEvaluation.8.ts
Decorators are not valid here.Unexpected token
Expect to Parse: tasks/coverage/typescript/tests/cases/conformance/expressions/asOperator/asOpEmitParens.ts
Expected a semicolon or an implicit semicolon after a statement, but found none
Expect to Parse: tasks/coverage/typescript/tests/cases/conformance/expressions/elementAccess/letIdentifierInElementAccess01.ts
Unexpected token
Expect to Parse: tasks/coverage/typescript/tests/cases/conformance/expressions/optionalChaining/optionalChainingInTypeAssertions.ts
Expected a semicolon or an implicit semicolon after a statement, but found none
Mismatch: tasks/coverage/typescript/tests/cases/conformance/expressions/typeGuards/typeGuardsInRightOperandOfAndAndOperator.ts

Mismatch: tasks/coverage/typescript/tests/cases/conformance/expressions/typeGuards/typeGuardsInRightOperandOfOrOrOperator.ts

Expect to Parse: tasks/coverage/typescript/tests/cases/conformance/generators/yieldStatementNoAsiAfterTransform.ts
Expected a semicolon or an implicit semicolon after a statement, but found none
Mismatch: tasks/coverage/typescript/tests/cases/conformance/generators/yieldStatementNoAsiAfterTransform.ts

Mismatch: tasks/coverage/typescript/tests/cases/conformance/interfaces/interfacesExtendingClasses/interfaceExtendingClassWithPrivates2.ts

Mismatch: tasks/coverage/typescript/tests/cases/conformance/interfaces/interfacesExtendingClasses/interfaceExtendingClassWithProtecteds2.ts

Expect to Parse: tasks/coverage/typescript/tests/cases/conformance/statements/returnStatements/returnStatementNoAsiAfterTransform.ts
Expected `,` but found `(`
Mismatch: tasks/coverage/typescript/tests/cases/conformance/statements/returnStatements/returnStatementNoAsiAfterTransform.ts

Mismatch: tasks/coverage/typescript/tests/cases/conformance/types/tuple/named/namedTupleMembers.ts

18 changes: 3 additions & 15 deletions tasks/prettier_conformance/snapshots/prettier.ts.snap.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
ts compatibility: 389/573 (67.89%)
ts compatibility: 401/573 (69.98%)

# Failed

Expand All @@ -16,18 +16,13 @@ ts compatibility: 389/573 (67.89%)
| typescript/argument-expansion/arrow-with-return-type.ts | 💥 | 89.47% |
| typescript/arrow/16067.ts | 💥💥 | 95.92% |
| typescript/arrow/comments.ts | 💥✨ | 44.44% |
| typescript/as/as.ts | 💥 | 74.02% |
| typescript/as/assignment.ts | 💥 | 86.67% |
| typescript/as/as.ts | 💥 | 85.04% |
| typescript/as/assignment2.ts | 💥 | 94.12% |
| typescript/as/export_default_as.ts | 💥 | 0.00% |
| typescript/as/expression-statement.ts | 💥 | 75.00% |
| typescript/as/long-identifiers.ts | 💥 | 92.86% |
| typescript/as/nested-await-and-as.ts | 💥 | 42.86% |
| typescript/as/ternary.ts | 💥 | 82.00% |
| typescript/assignment/issue-10846.ts | 💥 | 63.16% |
| typescript/assignment/issue-10848.tsx | 💥 | 52.12% |
| typescript/assignment/issue-10850.ts | 💥 | 50.00% |
| typescript/cast/as-const.ts | 💥 | 60.00% |
| typescript/cast/generic-cast.ts | 💥 | 39.60% |
| typescript/cast/tuple-and-record.ts | 💥 | 0.00% |
| typescript/chain-expression/call-expression.ts | 💥 | 68.75% |
Expand Down Expand Up @@ -102,7 +97,6 @@ ts compatibility: 389/573 (67.89%)
| typescript/enum/computed-members.ts | 💥 | 0.00% |
| typescript/export/comment.ts | 💥 | 50.00% |
| typescript/export/export.ts | 💥 | 85.71% |
| typescript/export-default/function_as.ts | 💥 | 0.00% |
| typescript/function-type/consistent.ts | 💥 | 70.83% |
| typescript/function-type/type-annotation.ts | 💥 | 0.00% |
| typescript/generic/arrow-return-type.ts | 💥 | 80.77% |
Expand Down Expand Up @@ -134,7 +128,6 @@ ts compatibility: 389/573 (67.89%)
| typescript/module/namespace_function.ts | 💥 | 66.67% |
| typescript/multiparser-css/issue-6259.ts | 💥 | 57.14% |
| typescript/new/new-signature.ts | 💥 | 93.85% |
| typescript/no-semi/non-null.ts | 💥💥 | 66.67% |
| typescript/non-null/optional-chain.ts | 💥 | 72.22% |
| typescript/non-null/parens.ts | 💥 | 96.00% |
| typescript/nosemi/index-signature.ts | 💥 | 75.00% |
Expand All @@ -148,15 +141,10 @@ ts compatibility: 389/573 (67.89%)
| typescript/prettier-ignore/prettier-ignore-parenthesized-type.ts | 💥 | 0.00% |
| typescript/rest-type/complex.ts | 💥 | 0.00% |
| typescript/rest-type/infer-type.ts | 💥 | 80.00% |
| typescript/satisfies-operators/assignment.ts | 💥💥 | 72.73% |
| typescript/satisfies-operators/export-default-as.ts | 💥💥 | 0.00% |
| typescript/satisfies-operators/assignment.ts | 💥💥 | 90.91% |
| typescript/satisfies-operators/expression-statement.ts | 💥💥 | 78.38% |
| typescript/satisfies-operators/gt-lt.ts | 💥💥 | 0.00% |
| typescript/satisfies-operators/lhs.ts | 💥✨ | 35.00% |
| typescript/satisfies-operators/nested-await-and-satisfies.ts | 💥💥 | 42.86% |
| typescript/satisfies-operators/non-null.ts | 💥💥 | 66.67% |
| typescript/satisfies-operators/satisfies.ts | 💥💥 | 81.82% |
| typescript/satisfies-operators/ternary.ts | 💥💥 | 82.00% |
| typescript/template-literal-types/template-literal-types.ts | 💥 | 80.00% |
| typescript/test-declarations/test_declarations.ts | 💥💥 | 66.67% |
| typescript/trailing-comma/arrow-functions.tsx | 💥💥💥 | 25.00% |
Expand Down
Loading