Skip to content

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Sep 17, 2025

Pure refactor. Export functions directly with export function instead of an additional export { ... } statement. This makes it easier to see which functions are exported and which are not.

@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Sep 17, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel self-assigned this Sep 17, 2025
@overlookmotel overlookmotel marked this pull request as ready for review September 17, 2025 11:11
Copilot AI review requested due to automatic review settings September 17, 2025 11:11
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Sep 17, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the export pattern in a parser module by moving from a centralized export statement to direct function exports. Instead of declaring functions and then listing them in an export { ... } statement, each function is now declared with the export keyword directly.

  • Removed the centralized export { ... } statement
  • Added export keyword to individual function declarations
  • Improved visibility of which functions are exported from the module

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Member Author

overlookmotel commented Sep 17, 2025

Merge activity

  • Sep 17, 11:11 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Sep 17, 11:21 AM UTC: Merged by the Graphite merge queue.

Pure refactor. Export functions directly with `export function` instead of an additional `export { ... }` statement. This makes it easier to see which functions are exported and which are not.
@graphite-app graphite-app bot force-pushed the 09-17-refactor_napi_parser_export_functions_directly branch from 38e0b2e to 42b1000 Compare September 17, 2025 11:16
@graphite-app graphite-app bot merged commit 42b1000 into main Sep 17, 2025
17 checks passed
@graphite-app graphite-app bot deleted the 09-17-refactor_napi_parser_export_functions_directly branch September 17, 2025 11:21
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Sep 17, 2025
@overlookmotel overlookmotel added the A-parser Area - Parser label Sep 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-parser Area - Parser C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants