Skip to content

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented Sep 18, 2025

Summary

  • Convert npm/oxc-types package to ES modules by setting "type": "module" in package.json

Test plan

  • Verify TypeScript definitions continue to work with both CommonJS and ESM consumers
  • Test imports in various module environments
  • Run existing test suites

🤖 Generated with Claude Code

Copilot AI review requested due to automatic review settings September 18, 2025 08:04
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR converts the npm/oxc-types package to ES modules by changing the package.json type field from "commonjs" to "module". The change also affects the npm/runtime package by adding the ES module type configuration.

Key Changes:

  • Updated npm/oxc-types/package.json to set "type": "module"
  • Updated npm/runtime/package.json to add "type": "module" and remove the previous "type": "commonjs"

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
npm/oxc-types/package.json Changed module type from CommonJS to ES modules
npm/runtime/package.json Added ES module type and removed CommonJS type declaration

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@graphite-app
Copy link
Contributor

graphite-app bot commented Sep 18, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added the C-enhancement Category - New feature or request label Sep 18, 2025
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Sep 18, 2025
Copy link
Member Author

Boshen commented Sep 18, 2025

Merge activity

## Summary
- Convert npm/oxc-types package to ES modules by setting `"type": "module"` in package.json

## Test plan
- [ ] Verify TypeScript definitions continue to work with both CommonJS and ESM consumers
- [ ] Test imports in various module environments
- [ ] Run existing test suites

🤖 Generated with [Claude Code](https://claude.ai/code)
@graphite-app graphite-app bot merged commit 89e9f5f into main Sep 18, 2025
17 checks passed
@graphite-app graphite-app bot deleted the feat/oxc-types-esm branch September 18, 2025 08:25
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Sep 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants