fix(build): bump package version in `apps/oxlint` in pre-release workflow #13895

overlookmotel · 2025-09-18T15:13:25Z

Package version is used by NAPI-RS in the bindings file it generates.

Adapt the pre-release workflow to run NAPI-RS build when creating a release PR, so that the version number in bindings files matches the new version number.

This change covers all NAPI packages in crates pre-release workflow, and also oxlint in its pre-release workflow.

overlookmotel · 2025-09-18T15:13:46Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

The version field is used by NAPI build. Bring it up to date. #13895 updates the pre-release workflow so it's kept in sync in future.

overlookmotel · 2025-09-18T16:22:47Z

@camc314 Are you familiar with the release workflows? I've requested Boshen's review, because my assumption was he's the only one who understands this side of things well. But maybe I'm wrong and you do too. If so, we could merge this.

camc314 · 2025-09-18T16:25:02Z

ish? lets try running the workflow > https://github.com/oxc-project/oxc/actions/runs/17835050852

camc314 · 2025-09-18T16:27:25Z

hmm it failed @overlookmotel https://github.com/oxc-project/oxc/actions/runs/17835050852/job/50709984838

codspeed-hq · 2025-09-19T09:33:20Z

CodSpeed Instrumentation Performance Report

Merging #13895 will not alter performance

_{Comparing 09-18-fix_build_bump_package_version_in_apps_oxlint_in_pre-release_workflow (4248ed8) with main (15eb326)¹}

Summary

✅ 37 untouched

No successful run was found on main (bd2fa90) during the generation of this report, so 15eb326 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

overlookmotel · 2025-09-19T09:39:29Z

Fixed now.

I ran the pre-release workflows on this PR's branch for crates, oxlint and oxfmt.

The resulting PRs: #13920, #13921, #13922.

All looks correct. The bindings files in napi/* and apps/oxlint all contain the updated version number.

Only problems are:

Duplicate changelogs in oxlint workflow (release(oxlint): v1.17.0 #13921). But I think that's a pre-existing problem, right?
Miri fail. Unrelated - there seems to be a memory leak in browserslist.

overlookmotel · 2025-09-20T08:41:34Z

Have tested it and it works, so merging.

overlookmotel · 2025-09-20T08:41:48Z

Merge activity

Sep 20, 8:41 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Sep 20, 8:41 AM UTC: overlookmotel added this pull request to the Graphite merge queue.
Sep 20, 8:55 AM UTC: Merged by the Graphite merge queue.

…flow (#13895) Package version is used by NAPI-RS in the bindings file it generates. Adapt the pre-release workflow to run NAPI-RS build when creating a release PR, so that the version number in bindings files matches the new version number. This change covers all NAPI packages in `crates` pre-release workflow, and also `oxlint` in its pre-release workflow.

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

github-actions bot added the C-bug Category - Bug label Sep 18, 2025

overlookmotel mentioned this pull request Sep 18, 2025

fix(napi): rebuild bindings file for NAPI packages #13889

Merged

overlookmotel mentioned this pull request Sep 18, 2025

fix(linter): set package version in package.json #13890

Merged

overlookmotel marked this pull request as ready for review September 18, 2025 15:15

overlookmotel requested a review from Boshen September 18, 2025 15:15

overlookmotel assigned Boshen Sep 18, 2025

graphite-app bot changed the base branch from 09-18-fix_linter_set_package_version_in_package.json_ to graphite-base/13895 September 18, 2025 15:21

graphite-app bot pushed a commit that referenced this pull request Sep 18, 2025

fix(linter): set package version in package.json (#13890)

dd3843f

The version field is used by NAPI build. Bring it up to date. #13895 updates the pre-release workflow so it's kept in sync in future.

overlookmotel force-pushed the graphite-base/13895 branch from 902ddb2 to dd3843f Compare September 18, 2025 15:22

overlookmotel force-pushed the 09-18-fix_build_bump_package_version_in_apps_oxlint_in_pre-release_workflow branch from 91e50b8 to fa421cf Compare September 18, 2025 15:22

overlookmotel changed the base branch from graphite-base/13895 to 09-18-fix_linter_set_package_version_in_package.json_ September 18, 2025 15:22

camc314 approved these changes Sep 18, 2025

View reviewed changes

Base automatically changed from 09-18-fix_linter_set_package_version_in_package.json_ to main September 18, 2025 15:25

overlookmotel mentioned this pull request Sep 18, 2025

release(oxlint): v1.17.0 #13856

Closed

overlookmotel changed the base branch from main to graphite-base/13895 September 19, 2025 09:21

overlookmotel force-pushed the 09-18-fix_build_bump_package_version_in_apps_oxlint_in_pre-release_workflow branch from fa421cf to 4248ed8 Compare September 19, 2025 09:21

overlookmotel changed the base branch from graphite-base/13895 to 09-19-fix_napi_parser_move_browser.js_file September 19, 2025 09:21

overlookmotel mentioned this pull request Sep 19, 2025

fix(napi/parser): move browser.js file #13918

Merged

Base automatically changed from 09-19-fix_napi_parser_move_browser.js_file to main September 19, 2025 09:24

This was referenced Sep 19, 2025

release(oxfmt): v0.3.0 #13920

Closed

release(oxlint): v1.17.0 #13921

Closed

release(crates): v0.91.0 #13922

Closed

Release 1.17.0 oxc-project/oxc-project.github.io#502

Closed

overlookmotel requested a review from camc314 September 19, 2025 09:42

overlookmotel added the 0-merge Merge with Graphite Merge Queue label Sep 20, 2025

overlookmotel assigned overlookmotel and unassigned Boshen Sep 20, 2025

graphite-app bot force-pushed the 09-18-fix_build_bump_package_version_in_apps_oxlint_in_pre-release_workflow branch from 4248ed8 to 807dbb3 Compare September 20, 2025 08:50

Copilot AI review requested due to automatic review settings September 20, 2025 08:50

Copilot AI reviewed Sep 20, 2025

View reviewed changes

graphite-app bot merged commit 807dbb3 into main Sep 20, 2025
19 checks passed

graphite-app bot deleted the 09-18-fix_build_bump_package_version_in_apps_oxlint_in_pre-release_workflow branch September 20, 2025 08:55

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Sep 20, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(build): bump package version in `apps/oxlint` in pre-release workflow #13895

fix(build): bump package version in `apps/oxlint` in pre-release workflow #13895

Uh oh!

overlookmotel commented Sep 18, 2025 •

edited

Loading

Uh oh!

overlookmotel commented Sep 18, 2025 •

edited

Loading

Uh oh!

overlookmotel commented Sep 18, 2025 •

edited

Loading

Uh oh!

camc314 commented Sep 18, 2025

Uh oh!

camc314 commented Sep 18, 2025

Uh oh!

codspeed-hq bot commented Sep 19, 2025

Uh oh!

overlookmotel commented Sep 19, 2025 •

edited

Loading

Uh oh!

overlookmotel commented Sep 20, 2025

Uh oh!

overlookmotel commented Sep 20, 2025 •

edited by graphite-app bot

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

fix(build): bump package version in apps/oxlint in pre-release workflow #13895

fix(build): bump package version in apps/oxlint in pre-release workflow #13895

Uh oh!

Conversation

overlookmotel commented Sep 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

overlookmotel commented Sep 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

overlookmotel commented Sep 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

camc314 commented Sep 18, 2025

Uh oh!

camc314 commented Sep 18, 2025

Uh oh!

codspeed-hq bot commented Sep 19, 2025

CodSpeed Instrumentation Performance Report

Merging #13895 will not alter performance

Summary

Footnotes

Uh oh!

overlookmotel commented Sep 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

overlookmotel commented Sep 20, 2025

Uh oh!

overlookmotel commented Sep 20, 2025 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

fix(build): bump package version in `apps/oxlint` in pre-release workflow #13895

fix(build): bump package version in `apps/oxlint` in pre-release workflow #13895

overlookmotel commented Sep 18, 2025 •

edited

Loading

overlookmotel commented Sep 18, 2025 •

edited

Loading

overlookmotel commented Sep 18, 2025 •

edited

Loading

overlookmotel commented Sep 19, 2025 •

edited

Loading

overlookmotel commented Sep 20, 2025 •

edited by graphite-app bot

Loading