Skip to content

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Sep 20, 2025

Add a structs_and_enums method to Schema which returns an iterator over all struct and enum definitions, skipping primitives, boxes, vecs, etc. This will be useful in many places in oxc_ast_tools.

Copy link
Member Author

overlookmotel commented Sep 20, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-enhancement Category - New feature or request label Sep 20, 2025
@overlookmotel overlookmotel marked this pull request as ready for review September 20, 2025 12:03
@overlookmotel overlookmotel self-assigned this Sep 20, 2025
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Sep 20, 2025
Copy link
Member Author

overlookmotel commented Sep 20, 2025

Merge activity

@codspeed-hq
Copy link

codspeed-hq bot commented Sep 20, 2025

CodSpeed Instrumentation Performance Report

Merging #13949 will not alter performance

Comparing 09-16-feat_ast_tools_add_schema_structs_and_enums_method (a4f5a3a) with main (f1862c4)1

Summary

✅ 37 untouched

Footnotes

  1. No successful run was found on main (a4f5a3a) during the generation of this report, so f1862c4 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@graphite-app graphite-app bot force-pushed the 09-16-refactor_ast_tools_move_structorenum_into_schema_module branch from 62fb53d to 7c7b6f4 Compare September 20, 2025 12:06
graphite-app bot pushed a commit that referenced this pull request Sep 20, 2025
Add a `structs_and_enums` method to `Schema` which returns an iterator over all struct and enum definitions, skipping primitives, boxes, vecs, etc. This will be useful in many places in `oxc_ast_tools`.
@graphite-app graphite-app bot force-pushed the 09-16-feat_ast_tools_add_schema_structs_and_enums_method branch from 4f6b270 to 683f5b9 Compare September 20, 2025 12:06
Add a `structs_and_enums` method to `Schema` which returns an iterator over all struct and enum definitions, skipping primitives, boxes, vecs, etc. This will be useful in many places in `oxc_ast_tools`.
@graphite-app graphite-app bot force-pushed the 09-16-refactor_ast_tools_move_structorenum_into_schema_module branch from 7c7b6f4 to 43b74af Compare September 20, 2025 12:09
@graphite-app graphite-app bot force-pushed the 09-16-feat_ast_tools_add_schema_structs_and_enums_method branch from 683f5b9 to a4f5a3a Compare September 20, 2025 12:09
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Sep 20, 2025
Base automatically changed from 09-16-refactor_ast_tools_move_structorenum_into_schema_module to main September 20, 2025 12:15
@graphite-app graphite-app bot merged commit a4f5a3a into main Sep 20, 2025
27 checks passed
@graphite-app graphite-app bot deleted the 09-16-feat_ast_tools_add_schema_structs_and_enums_method branch September 20, 2025 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast-tools Area - AST tools C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants