Skip to content

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented Sep 20, 2025

Copilot AI review requested due to automatic review settings September 20, 2025 12:36
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug in the playground's minification logic where both compression and mangling were applied regardless of whether the mangle option was enabled. The fix ensures that compression and mangling are only applied when their respective options are enabled.

Key Changes:

  • Restructured conditional logic to handle compression and mangling options separately
  • Added early return when neither compression nor mangling are enabled
  • Ensured minifier only applies transformations when explicitly requested

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions github-actions bot added the C-bug Category - Bug label Sep 20, 2025
Copy link
Member Author

Boshen commented Sep 20, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@graphite-app
Copy link
Contributor

graphite-app bot commented Sep 20, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 09-20-fix_napi_playground_only_mangle_only_if_mangle_option_is_enabled branch from 8592a20 to eb7bf35 Compare September 20, 2025 12:41
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Sep 20, 2025
@graphite-app graphite-app bot force-pushed the 09-20-fix_napi_playground_only_mangle_only_if_mangle_option_is_enabled branch from eb7bf35 to 7eead3b Compare September 20, 2025 12:43
@Boshen Boshen changed the title fix(napi/playground): only mangle only if mangle option is enabled fix(napi/playground): only mangle if mangle option is enabled Sep 20, 2025
@graphite-app graphite-app bot merged commit 7eead3b into main Sep 20, 2025
18 checks passed
@graphite-app graphite-app bot deleted the 09-20-fix_napi_playground_only_mangle_only_if_mangle_option_is_enabled branch September 20, 2025 12:48
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Sep 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Minify syntax" control also enables symbol mangling

2 participants