Skip to content

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Sep 21, 2025

#13899 made the files array in package.json for napi/parser package a short list of directories. Revert to an itemized list of all files to be included in NPM package.

This is for compatibility with the release workflow which checks the list of files in package.json against file system. It fails when files list contains directories.

@github-actions github-actions bot added A-parser Area - Parser C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Sep 21, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review September 21, 2025 14:44
Copilot AI review requested due to automatic review settings September 21, 2025 14:44
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reverts the files array in package.json from a directory-based list to an itemized list of specific files for NPM package inclusion. This change ensures compatibility with the release workflow that validates individual files rather than directories.

  • Replace directory entries ("generated", "src-js") with explicit file paths
  • List all 17 individual files that should be included in the NPM package
  • Maintain the same file coverage but with granular control over package contents

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@overlookmotel overlookmotel removed the request for review from Boshen September 21, 2025 14:51
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Sep 21, 2025
Copy link
Member Author

overlookmotel commented Sep 21, 2025

Merge activity

#13899 made the `files` array in `package.json` for `napi/parser` package a short list of directories. Revert to an itemized list of all files to be included in NPM package.

This is for compatibility with the release workflow which checks the list of files in `package.json` against file system. It fails when `files` list contains directories.
@graphite-app graphite-app bot force-pushed the 09-21-refactor_napi_parser_itemize_files_in_package.json_ branch from 57c9e87 to 48062d0 Compare September 21, 2025 14:52
@graphite-app graphite-app bot merged commit 48062d0 into main Sep 21, 2025
17 checks passed
@graphite-app graphite-app bot deleted the 09-21-refactor_napi_parser_itemize_files_in_package.json_ branch September 21, 2025 14:56
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Sep 21, 2025
This was referenced Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-parser Area - Parser C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants