-
-
Notifications
You must be signed in to change notification settings - Fork 716
refactor(napi/parser): itemize files in package.json
#13978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(napi/parser): itemize files in package.json
#13978
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR reverts the files array in package.json from a directory-based list to an itemized list of specific files for NPM package inclusion. This change ensures compatibility with the release workflow that validates individual files rather than directories.
- Replace directory entries ("generated", "src-js") with explicit file paths
- List all 17 individual files that should be included in the NPM package
- Maintain the same file coverage but with granular control over package contents
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Merge activity
|
#13899 made the `files` array in `package.json` for `napi/parser` package a short list of directories. Revert to an itemized list of all files to be included in NPM package. This is for compatibility with the release workflow which checks the list of files in `package.json` against file system. It fails when `files` list contains directories.
57c9e87 to
48062d0
Compare

#13899 made the
filesarray inpackage.jsonfornapi/parserpackage a short list of directories. Revert to an itemized list of all files to be included in NPM package.This is for compatibility with the release workflow which checks the list of files in
package.jsonagainst file system. It fails whenfileslist contains directories.