Skip to content

ci(release): fix release workflow for NAPI packages #13979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 21, 2025
Merged

ci(release): fix release workflow for NAPI packages #13979

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions .github/workflows/reusable_release_napi.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,9 +134,10 @@ jobs:
with:
if-no-files-found: error
name: bindings-${{ matrix.target }}
# `**/*.node` because in `napi/parser`, binaries are in `src-js` subdirectory
path: |
napi/${{ inputs.name }}/*.node
napi/${{ inputs.name }}/*.wasm
napi/${{ inputs.name }}/**/*.node
napi/${{ inputs.name }}/**/*.wasm

build-freebsd:
needs: check
Expand Down Expand Up @@ -183,7 +184,8 @@ jobs:
with:
if-no-files-found: error
name: bindings-freebsd
path: napi/${{ inputs.name }}/*.node
# `**/*.node` because in `napi/parser`, binary is in `src-js` subdirectory
path: napi/${{ inputs.name }}/**/*.node

publish:
name: Publish NAPI
Expand All @@ -207,11 +209,15 @@ jobs:
with:
path: artifacts

- run: mkdir -p release-dir
- run: mkdir -p ${npm_dir}

- run: pnpm napi create-npm-dirs --package-json-path ${package_path}/package.json --npm-dir ${npm_dir}

- run: pnpm napi artifacts --package-json-path ${package_path}/package.json --build-output-dir ${package_path}/src-js --npm-dir ${npm_dir}
if: ${{ inputs.name == 'parser' }}

- run: pnpm napi artifacts --package-json-path ${package_path}/package.json --build-output-dir ${package_path} --npm-dir ${npm_dir}
if: ${{ inputs.name != 'parser' }}

- run: pnpm -C ${package_path} build-browser-bundle --npmDir ../../${npm_dir}
if: ${{ inputs.name == 'parser' }}
Expand Down
2 changes: 1 addition & 1 deletion napi/parser/scripts/build-browser-bundle.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ async function main() {
pkg.files.push('browser-bundle.mjs');
fs.writeFileSync(pkgFile, JSON.stringify(pkg, null, 2));

// copy `browser-bundle.mjs` to `npm-dir/wasm32-wasi`
// copy `browser-bundle.mjs` to `<npmDir>/wasm32-wasi`
fs.cpSync('browser-bundle.mjs', path.join(pkgDir, 'browser-bundle.mjs'));
}
}
Expand Down
Loading