Skip to content

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Sep 23, 2025

Fix just oxlint and just watch-oxlint. They were broken because oxlint is now a NAPI package.

Remove cargo oxlint command, because oxlint needs to be built with NAPI-RS now.

@github-actions github-actions bot added the C-bug Category - Bug label Sep 23, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review September 23, 2025 08:34
Copilot AI review requested due to automatic review settings September 23, 2025 08:34
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the just oxlint and just watch-oxlint commands by updating them to work with oxlint as a NAPI package instead of a Rust binary.

  • Replace cargo oxlint with NAPI-based build command using pnpm
  • Update watch command to use Node.js instead of cargo run
  • Remove deprecated cargo alias for oxlint

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
justfile Updates oxlint and watch-oxlint commands to use NAPI build and Node.js execution
.cargo/config.toml Removes the deprecated cargo oxlint alias

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Sep 23, 2025
Copy link
Member

Boshen commented Sep 23, 2025

Merge activity

Fix `just oxlint` and `just watch-oxlint`. They were broken because `oxlint` is now a NAPI package.

Remove `cargo oxlint` command, because `oxlint` needs to be built with NAPI-RS now.
@graphite-app graphite-app bot force-pushed the 09-23-fix_tools_fix_just_oxlint_and_just_watch-oxlint_ branch from adb0411 to a47cb9a Compare September 23, 2025 10:08
@graphite-app graphite-app bot merged commit a47cb9a into main Sep 23, 2025
17 checks passed
@graphite-app graphite-app bot deleted the 09-23-fix_tools_fix_just_oxlint_and_just_watch-oxlint_ branch September 23, 2025 10:14
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants