refactor(linter): rename LintRunner to CliRunner
#14050
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-linter
Contributor
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Sep 23, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR renames the LintRunner struct to CliRunner throughout the codebase to better reflect its role as a general CLI runner rather than being specifically tied to linting functionality.
- Renamed the main struct from
LintRunnertoCliRunner - Updated all references and imports across multiple files
- Enhanced linter configuration with conditional unused directive reporting
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| apps/oxlint/src/tester.rs | Updated imports and instantiation calls to use CliRunner |
| apps/oxlint/src/run.rs | Updated import and usage of the renamed struct |
| apps/oxlint/src/lint.rs | Renamed struct definition, implementations, and test references; added conditional linter configuration |
| apps/oxlint/src/lib.rs | Updated public re-export to use new CliRunner name |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
camc314
force-pushed
the
c/09-23-refactor_linter_rename_lintrunner_to_clirunner_
branch
from
d17e224 to
06b61a6
Compare
Contributor
Author
Merge activity
|
This commit renames `LintRunner` to `CliRunner` . This change is being made in preparation for introducing a new `LintRunner` component in the future. In future, `LintRunner` (living in `oxc_linter`) will handle the tsgolint/oxlint coordination (and state storage between the two phases)
graphite-app
bot
force-pushed
the
c/09-23-refactor_linter_rename_lintrunner_to_clirunner_
branch
from
06b61a6 to
3a706a7
Compare
graphite-app
bot
deleted the
c/09-23-refactor_linter_rename_lintrunner_to_clirunner_
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit renames
LintRunnertoCliRunner. This change is being made in preparation for introducing a newLintRunnercomponent in the future.In future,
LintRunner (living inoxc_linter) will handle the tsgolint/oxlint coordination (and state storage between the two phases)