perf(language_server): avoid cloning on message conversion

[Sysix]

Tested it with one no-debugger rule on a file (100 times).

Main:

heaptrack stats:
        allocations:            172985
        leaked allocations:     580
        temporary allocations:  53112

This PR:

heaptrack stats:
        allocations:            170985
        leaked allocations:     580
        temporary allocations:  53111

[Sysix]

• perf(language_server): avoid cloning on message conversion #14058 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[Copilot]

Pull Request Overview

This PR optimizes memory allocation in the language server by removing unnecessary references and clones when converting messages. The performance improvement reduces allocations from 172,985 to 170,985 in benchmark testing.

• Removes reference taking (&) in function calls to avoid unnecessary clones
• Adds inner_owned() method to consume OxcDiagnostic and return owned inner data
• Refactors message conversion functions to reuse logic and eliminate code duplication

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
crates/oxc_linter/src/tsgolint.rs	Removes reference taking when converting tsgo lint diagnostic to message
crates/oxc_linter/src/service/runtime.rs	Removes references in diagnostic and message conversion calls
crates/oxc_linter/src/lsp.rs	Refactors message conversion to avoid cloning and reuse existing logic
crates/oxc_diagnostics/src/lib.rs	Adds inner_owned() method to consume diagnostic and return owned data

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[codspeed-hq]

CodSpeed Instrumentation Performance Report

Merging #14058 will not alter performance

_{Comparing 09-23-perf_language_server_avoid_cloning_on_message_conversation (c2f7459) with main (444fcf0)¹}

Summary

✅ 37 untouched

Footnotes

1. No successful run was found on main (c2f7459) during the generation of this report, so 444fcf0 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

[camc314]

Merge activity

• Sep 24, 8:57 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Sep 24, 8:57 AM UTC: camc314 added this pull request to the Graphite merge queue.
• Sep 24, 9:03 AM UTC: Merged by the Graphite merge queue.