Skip to content

fix(linter): Fix false positive in no-restricted-globals #14135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 26, 2025
Merged

fix(linter): Fix false positive in no-restricted-globals #14135

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion crates/oxc_linter/src/rules/eslint/no_restricted_globals.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,10 @@ impl Rule for NoRestrictedGlobals {
};

if ctx.scoping().root_unresolved_references().contains_key(ident.name.as_str()) {
ctx.diagnostic(no_restricted_globals(&ident.name, message, ident.span));
let reference = ctx.scoping().get_reference(ident.reference_id());
if !reference.is_type() {
ctx.diagnostic(no_restricted_globals(&ident.name, message, ident.span));
}
}
}
}
Expand All @@ -99,6 +102,13 @@ fn test() {
const CUSTOM_MESSAGE: &str = "Use bar instead.";

let pass = vec![
(
"let a: Date;",
Some(
serde_json::json!([{ "name": "Date", "message": "Use helpers or date-fns instead", }]),
),
None,
),
("foo", None, None),
("foo", Some(serde_json::json!(["bar"])), None),
("var foo = 1;", Some(serde_json::json!(["foo"])), None),
Expand Down
Loading