Skip to content

Conversation

@ulrichstark
Copy link
Contributor

The match above the deleted line already reports depending on the kind of method.

Copilot AI review requested due to automatic review settings September 28, 2025 03:12
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request fixes a duplicate error reporting issue in the TypeScript semantic checker where abstract methods with implementation were being reported twice.

  • Removes redundant error reporting for abstract methods with implementation
  • Fixes double error messages by relying on existing match statement handling

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions github-actions bot added A-semantic Area - Semantic C-bug Category - Bug labels Sep 28, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Sep 28, 2025

CodSpeed Instrumentation Performance Report

Merging #14193 will not alter performance

Comparing ulrichstark:don't-report-abstract-method-with-implementation-twice (6e9370d) with main (5b74a81)1

Summary

✅ 37 untouched

Footnotes

  1. No successful run was found on main (5dcc64c) during the generation of this report, so 5b74a81 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Sep 28, 2025
@Boshen Boshen merged commit f2fd7da into oxc-project:main Sep 28, 2025
26 checks passed
@graphite-app
Copy link
Contributor

graphite-app bot commented Sep 28, 2025

Merge activity

  • Sep 28, 4:18 AM UTC: @ulrichstark we removed the merge queue label because we could not find a Graphite account associated with your GitHub profile.

You must have a Graphite account in order to use the merge queue. Create an account and try again using this link

@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Sep 28, 2025
@ulrichstark ulrichstark deleted the don't-report-abstract-method-with-implementation-twice branch September 28, 2025 04:20
taearls pushed a commit to taearls/oxc that referenced this pull request Sep 28, 2025
…oxc-project#14193)

The match above the deleted line already reports depending on the kind
of method.
taearls pushed a commit to taearls/oxc that referenced this pull request Sep 28, 2025
…oxc-project#14193)

The match above the deleted line already reports depending on the kind
of method.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-semantic Area - Semantic C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants