Skip to content

fix(linter/react-hooks): fix diagnostic message for duplicate dependency in array #14265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 30, 2025
Merged

fix(linter/react-hooks): fix diagnostic message for duplicate dependency in array #14265

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions crates/oxc_linter/src/rules/react/exhaustive_deps.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,10 +119,10 @@ fn dependency_array_not_array_literal_diagnostic(hook_name: &str, span: Span) ->
.with_error_code_scope(SCOPE)
}

fn literal_in_dependency_array_diagnostic(span: Span) -> OxcDiagnostic {
OxcDiagnostic::warn("The literal is not a valid dependency because it never changes.")
fn duplicate_dependency_diagnostic(span: Span) -> OxcDiagnostic {
OxcDiagnostic::warn("This dependency is specified more than once in the dependency array.")
.with_label(span)
.with_help("Remove the literal from the array.")
.with_help("Remove the duplicate dependency from the array.")
.with_error_code_scope(SCOPE)
}

Expand Down Expand Up @@ -545,7 +545,7 @@ impl Rule for ExhaustiveDeps {
for item in declared_dependencies_iter {
let span = item.span;
if !declared_dependencies.insert(item) {
ctx.diagnostic(literal_in_dependency_array_diagnostic(span));
ctx.diagnostic(duplicate_dependency_diagnostic(span));
}
}

Expand Down
8 changes: 4 additions & 4 deletions crates/oxc_linter/src/snapshots/react_exhaustive_deps.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,14 +328,14 @@ source: crates/oxc_linter/src/tester.rs
╰────
help: Either include it or remove the dependency array.

⚠ eslint-plugin-react-hooks(exhaustive-deps): The literal is not a valid dependency because it never changes.
⚠ eslint-plugin-react-hooks(exhaustive-deps): This dependency is specified more than once in the dependency array.
╭─[exhaustive_deps.tsx:6:22]
5 │ console.log(local);
6 │ }, [local, local]);
· ─────
7 │ }
╰────
help: Remove the literal from the array.
help: Remove the duplicate dependency from the array.

⚠ eslint-plugin-react-hooks(exhaustive-deps): React hook useEffect depends on `local`, which changes every render
╭─[exhaustive_deps.tsx:2:17]
Expand Down Expand Up @@ -877,14 +877,14 @@ source: crates/oxc_linter/src/tester.rs
╰────
help: Either include it or remove the dependency array.

⚠ eslint-plugin-react-hooks(exhaustive-deps): The literal is not a valid dependency because it never changes.
⚠ eslint-plugin-react-hooks(exhaustive-deps): This dependency is specified more than once in the dependency array.
╭─[exhaustive_deps.tsx:5:22]
4 │ console.log(local);
5 │ }, [local, local]);
· ─────
6 │ }
╰────
help: Remove the literal from the array.
help: Remove the duplicate dependency from the array.

⚠ eslint-plugin-react-hooks(exhaustive-deps): React hook useEffect depends on `local`, which changes every render
╭─[exhaustive_deps.tsx:5:15]
Expand Down
Loading