Skip to content

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Oct 4, 2025

Pure refactor. Generate the various deserializers with a loop, rather than specifying each individually. This makes it easier to add more deserializers (next PR).

@github-actions github-actions bot added A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Oct 4, 2025
Copy link
Member Author

overlookmotel commented Oct 4, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review October 5, 2025 00:04
Copilot AI review requested due to automatic review settings October 5, 2025 00:04
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the deserializer generation code to use a loop-based approach instead of hardcoding each deserializer variant. The refactor replaces the Codes struct with a vector of (name, code) tuples and generates deserializers using nested loops for different flag combinations.

  • Replaced manual deserializer creation with a loop-based approach using flag combinations
  • Removed the Codes struct and its individual fields
  • Updated the function to return a vector of tuples instead of a structured container

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@overlookmotel overlookmotel self-assigned this Oct 5, 2025
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Oct 5, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 5, 2025

Merge activity

)

Pure refactor. Generate the various deserializers with a loop, rather than specifying each individually. This makes it easier to add more deserializers (next PR).
@graphite-app graphite-app bot force-pushed the 10-04-refactor_ast_tools_raw_transfer_generate_deserializers_in_loop branch from f4119a6 to 08f14e6 Compare October 5, 2025 00:32
@graphite-app graphite-app bot merged commit 08f14e6 into main Oct 5, 2025
17 checks passed
@graphite-app graphite-app bot deleted the 10-04-refactor_ast_tools_raw_transfer_generate_deserializers_in_loop branch October 5, 2025 00:37
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants