-
-
Notifications
You must be signed in to change notification settings - Fork 713
refactor(ast_tools/raw_transfer): generate deserializers in loop #14343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(ast_tools/raw_transfer): generate deserializers in loop #14343
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the deserializer generation code to use a loop-based approach instead of hardcoding each deserializer variant. The refactor replaces the Codes struct with a vector of (name, code) tuples and generates deserializers using nested loops for different flag combinations.
- Replaced manual deserializer creation with a loop-based approach using flag combinations
- Removed the
Codesstruct and its individual fields - Updated the function to return a vector of tuples instead of a structured container
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Merge activity
|
f4119a6 to
08f14e6
Compare

Pure refactor. Generate the various deserializers with a loop, rather than specifying each individually. This makes it easier to add more deserializers (next PR).