Skip to content

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Oct 6, 2025

No description provided.

@github-actions github-actions bot added A-parser Area - Parser C-enhancement Category - New feature or request labels Oct 6, 2025
@camc314 camc314 marked this pull request as ready for review October 6, 2025 22:10
Copy link
Contributor Author

camc314 commented Oct 6, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copilot AI review requested due to automatic review settings October 6, 2025 22:10
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the parser's raw transfer tests from JavaScript to TypeScript by updating import statements and TypeScript configuration. This change enables TypeScript file imports and removes the need for .js extensions in import paths.

  • Updates tsconfig.json to allow importing TypeScript extensions
  • Changes import statements from .js to .ts extensions
  • Updates worker pool filename to reference TypeScript file

Reviewed Changes

Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.

File Description
napi/parser/tsconfig.json Enables TypeScript extension imports by adding allowImportingTsExtensions
napi/parser/test/parse-raw.test.ts Updates imports to use .ts extensions and removes .js extension
napi/parser/test/parse-raw-worker.ts Updates import statements to reference TypeScript files

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Oct 6, 2025
Copy link
Member

overlookmotel commented Oct 6, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the c/10-06-feat_parser_use_typescript_for_raw_transfer_tests branch from 42b0ee8 to b3c5132 Compare October 6, 2025 23:27
@graphite-app graphite-app bot merged commit b3c5132 into main Oct 6, 2025
17 checks passed
@graphite-app graphite-app bot deleted the c/10-06-feat_parser_use_typescript_for_raw_transfer_tests branch October 6, 2025 23:32
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-parser Area - Parser C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants