Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -172,8 +172,8 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest, windows-latest]
exclude:
- os: ${{ github.ref_name != 'main' && 'windows-latest' || '' }}
# exclude:
# - os: ${{ github.ref_name != 'main' && 'windows-latest' || '' }}
Comment on lines +175 to +176
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: revert me before merge

runs-on: ${{ matrix.os }}
steps:
- name: Enable long paths on Windows
Expand Down
3 changes: 2 additions & 1 deletion apps/oxlint/src-js/plugins/load.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import { pathToFileURL } from 'node:url';
import { Context } from './context.js';
import { getErrorMessage } from './utils.js';

Expand Down Expand Up @@ -100,7 +101,7 @@ async function loadPluginImpl(path: string): Promise<PluginDetails> {
throw new Error('This plugin has already been registered. This is a bug in Oxlint. Please report it.');
}

const { default: plugin } = (await import(path)) as { default: Plugin };
const { default: plugin } = (await import(pathToFileURL(path).href)) as { default: Plugin };

registeredPluginPaths.add(path);

Expand Down
4 changes: 1 addition & 3 deletions apps/oxlint/test/e2e.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,7 @@ async function testFixture(fixtureName: string, options?: TestOptions): Promise<
});
}

describe.skipIf(
process.platform === 'win32',
)('oxlint CLI', () => {
describe('oxlint CLI', () => {
it('should lint a directory without errors', async () => {
await testFixture('built_in_no_errors', { args: [] });
});
Expand Down
2 changes: 1 addition & 1 deletion apps/oxlint/test/eslint-compat.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ async function testFixture(fixtureName: string): Promise<void> {
});
}

describe.skipIf(process.platform === 'win32')('ESLint compatibility', () => {
describe('ESLint compatibility', () => {
it('`definePlugin` should work', async () => {
await testFixture('definePlugin');
});
Expand Down
Loading