Skip to content

perf(linter/plugins): avoid private methods #14418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 7, 2025
Merged

perf(linter/plugins): avoid private methods #14418

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
84 changes: 42 additions & 42 deletions apps/oxlint/src-js/plugins/context.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ export class Context {
let message: string;
if (hasOwn(diagnostic, 'messageId')) {
const diagWithMessageId = diagnostic as DiagnosticWithMessageId;
message = this.#resolveMessage(diagWithMessageId.messageId, diagWithMessageId.data, internal);
message = resolveMessage(diagWithMessageId.messageId, diagWithMessageId.data, internal);
} else {
message = diagnostic.message;
if (typeof message !== 'string') {
Expand Down Expand Up @@ -212,47 +212,6 @@ export class Context {
});
}

/**
* Resolve a messageId to its message string, with optional data interpolation.
* @param messageId - The message ID to resolve
* @param data - Optional data for placeholder interpolation
* @param internal - Internal context containing messages
* @returns Resolved message string
* @throws {Error} If messageId is not found in messages
*/
#resolveMessage(
messageId: string,
data: Record<string, string | number> | undefined,
internal: InternalContext,
): string {
const { messages } = internal;

if (!messages) {
throw new Error(`Cannot use messageId '${messageId}' - rule does not define any messages in meta.messages`);
}

if (!hasOwn(messages, messageId)) {
throw new Error(
`Unknown messageId '${messageId}'. Available messages: ${
Object.keys(messages).map((msg) => `'${msg}'`).join(', ')
}`,
);
}

let message = messages[messageId];

// Interpolate placeholders {{key}} with data values
if (data) {
message = message.replace(/\{\{([^}]+)\}\}/g, (match, key) => {
key = key.trim();
const value = data[key];
return value !== undefined ? String(value) : match;
});
}

return message;
}

static {
setupContextForFile = (context, ruleIndex, filePath) => {
// TODO: Support `options`
Expand All @@ -268,3 +227,44 @@ export class Context {
};
}
}

/**
* Resolve a message ID to its message string, with optional data interpolation.
* @param messageId - The message ID to resolve
* @param data - Optional data for placeholder interpolation
* @param internal - Internal context containing messages
* @returns Resolved message string
* @throws {Error} If `messageId` is not found in `messages`
*/
function resolveMessage(
messageId: string,
data: Record<string, string | number> | undefined,
internal: InternalContext,
): string {
const { messages } = internal;

if (!messages) {
throw new Error(`Cannot use messageId '${messageId}' - rule does not define any messages in meta.messages`);
}

if (!hasOwn(messages, messageId)) {
throw new Error(
`Unknown messageId '${messageId}'. Available messages: ${
Object.keys(messages).map((msg) => `'${msg}'`).join(', ')
}`,
);
}

let message = messages[messageId];

// Interpolate placeholders {{key}} with data values
if (data) {
message = message.replace(/\{\{([^}]+)\}\}/g, (match, key) => {
key = key.trim();
const value = data[key];
return value !== undefined ? String(value) : match;
});
}

return message;
}
Loading