Skip to content

fix(napi/minify): handle boolean values for compress.unused option #14513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 15, 2025
Merged

fix(napi/minify): handle boolean values for compress.unused option #14513

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a05901
fix(napi/minify): support boolean values for `compress.unused` option
sushichan044 Oct 14, 2025
df5926c
fix: mark invalid value as error
sushichan044 Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions napi/minify/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,12 @@ export interface CompressOptions {
*/
dropDebugger?: boolean
/**
* Drop unreferenced functions and variables.
* Pass `true` to drop unreferenced functions and variables.
*
* Simple direct variable assignments do not count as references unless set to "keep_assign".
* Simple direct variable assignments do not count as references unless set to `keep_assign`.
* @default true
*/
unused?: true | false | 'keep_assign'
unused?: boolean | 'keep_assign'
/** Keep function / class names. */
keepNames?: CompressOptionsKeepNames
/**
Expand Down
20 changes: 14 additions & 6 deletions napi/minify/src/options.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,12 @@ pub struct CompressOptions {
/// @default true
pub drop_debugger: Option<bool>,

/// Drop unreferenced functions and variables.
/// Pass `true` to drop unreferenced functions and variables.
///
/// Simple direct variable assignments do not count as references unless set to "keep_assign".
#[napi(ts_type = "true | false | 'keep_assign'")]
pub unused: Option<String>,
/// Simple direct variable assignments do not count as references unless set to `keep_assign`.
/// @default true
#[napi(ts_type = "boolean | 'keep_assign'")]
pub unused: Option<Either<bool, String>>,

/// Keep function / class names.
pub keep_names: Option<CompressOptionsKeepNames>,
Expand Down Expand Up @@ -69,8 +70,15 @@ impl TryFrom<&CompressOptions> for oxc_minifier::CompressOptions {
drop_debugger: o.drop_debugger.unwrap_or(default.drop_debugger),
join_vars: o.join_vars.unwrap_or(true),
sequences: o.sequences.unwrap_or(true),
// TODO
unused: oxc_minifier::CompressOptionsUnused::Keep,
unused: match &o.unused {
Some(Either::A(true)) => oxc_minifier::CompressOptionsUnused::Remove,
Some(Either::A(false)) => oxc_minifier::CompressOptionsUnused::Keep,
Some(Either::B(s)) => match s.as_str() {
"keep_assign" => oxc_minifier::CompressOptionsUnused::KeepAssign,
_ => return Err(format!("Invalid unused option: `{s}`.")),
},
None => default.unused,
},
keep_names: o.keep_names.as_ref().map(Into::into).unwrap_or_default(),
treeshake: TreeShakeOptions::default(),
max_iterations: o.passes,
Expand Down
Loading