Skip to content

Conversation

@lilnasy
Copy link
Contributor

@lilnasy lilnasy commented Oct 13, 2025

@lilnasy lilnasy requested a review from camc314 as a code owner October 13, 2025 05:06
@lilnasy lilnasy requested review from Copilot and removed request for camc314 October 13, 2025 05:06
@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 13, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-linter Area - Linter C-bug Category - Bug labels Oct 13, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug where external JavaScript plugin rules were being lost when applying ESLint config overrides. The issue was that the code was creating an empty external_rules map instead of copying over the base external rules when processing overrides.

  • Fixed initialization of external_rules to preserve base external rules when applying overrides
  • Added a comprehensive test case that reproduces the bug and verifies the fix

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 13, 2025

CodSpeed Performance Report

Merging #14542 will not alter performance

Comparing lilnasy:fix/14504 (b70385b) with main (9cd7a67)

Summary

✅ 4 untouched
⏩ 33 skipped1

Footnotes

  1. 33 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@camc314 camc314 self-assigned this Oct 13, 2025
@lilnasy lilnasy force-pushed the fix/14504 branch 3 times, most recently from 0fe37ea to 7d2e7c9 Compare October 15, 2025 07:14
Copy link
Contributor

@camc314 camc314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@camc314 camc314 merged commit c69201c into oxc-project:main Oct 16, 2025
20 checks passed
@lilnasy lilnasy deleted the fix/14504 branch October 16, 2025 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

linter: overrides disables JS plugins

2 participants