-
-
Notifications
You must be signed in to change notification settings - Fork 716
fix(linter): copy over js plugins when applying overrides #14542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a bug where external JavaScript plugin rules were being lost when applying ESLint config overrides. The issue was that the code was creating an empty external_rules map instead of copying over the base external rules when processing overrides.
- Fixed initialization of external_rules to preserve base external rules when applying overrides
- Added a comprehensive test case that reproduces the bug and verifies the fix
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
CodSpeed Performance ReportMerging #14542 will not alter performanceComparing Summary
Footnotes
|
0fe37ea to
7d2e7c9
Compare
Signed-off-by: Arsh <emmagoldmanvevo+github@pm.me>
camc314
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!
overridesdisables JS plugins #14504