fix(oxlint): resolving JS plugin failing when extends is used

[camc314]

No description provided.

[camc314]

• test(oxlint): add test for nested configs importing the same plugin 2x #14646
• fix(oxlint): resolving JS plugin failing when extends is used #14556 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Performance Report

Merging #14556 will not alter performance

_{Comparing c/10-13-add_repro (55becc5) with main (6bb9902)}

Summary

✅ 4 untouched
⏩ 33 skipped¹

Footnotes

1. 33 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[Copilot]

Pull Request Overview

This PR fixes an issue where JS plugin loading fails when configuration files use the extends feature. The fix involves changing how external plugins are handled internally to track both their specifiers and the directory containing the configuration file that references them.

Key changes:

• Removed the default null value for jsPlugins in schema files to fix serialization issues
• Modified external plugin storage to include configuration directory paths alongside plugin specifiers
• Updated plugin resolution logic to use the correct directory for relative plugin paths

Reviewed Changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
tasks/website/src/linter/snapshots/schema_markdown.snap	Removes default null value from jsPlugins documentation
npm/oxlint/configuration_schema.json	Removes default null value from jsPlugins schema
crates/oxc_linter/src/snapshots/schema_json.snap	Removes default null value from jsPlugins schema
crates/oxc_linter/src/config/oxlintrc.rs	Adds custom serialization/deserialization and path tracking for external plugins
crates/oxc_linter/src/config/overrides.rs	Adds custom serialization/deserialization for external plugins in overrides
crates/oxc_linter/src/config/config_builder.rs	Updates plugin loading logic to use configuration directory paths
apps/oxlint/test/fixtures/custom_plugin_nested_config/*	Adds test fixtures for nested configuration scenario
apps/oxlint/test/e2e.test.ts	Adds test case for custom plugin with nested config
apps/oxlint/src/snapshots/*	Updates snapshots to reflect removal of default null values

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[overlookmotel]

I'm a bit confused by the Option<PathBuf> - please see comments below.

I'm also unsure if we've introduced the possibility of same plugin getting loaded twice, because ("/foo/bar", "./plugin.js") and ("/foo/bar/qux", "../plugin.js") resolve to the same path, but do not hash the same.

But even if the latter is possible, it's an edge case, so I think we could merge this and deal with that oddity in a later PR.

[camc314]

m also unsure if we've introduced the possibility of same plugin getting loaded twice, because ("/foo/bar", "./plugin.js") and ("/foo/bar/qux", "../plugin.js") resolve to the same path, but do not hash the same.

But even if the latter is possible, it's an edge case, so I think we could merge this and deal with that oddity in a later PR.

let me add a test in a follow up PR. i've got no idea. EDIT: looks like we handle this already, but i added a test in the follow up to prevent any regressions

Option<PathBuf> is gone! it looks much better now.

[camc314]

Merge activity

• Oct 20, 10:03 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Oct 20, 10:03 AM UTC: camc314 added this pull request to the Graphite merge queue.
• Oct 20, 10:08 AM UTC: Merged by the Graphite merge queue.