fix(napi/minify): s/passes/max_iterations to avoid confusion #14608
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR renames a field in the CompressOptions struct from passes to max_iterations to better reflect its actual behavior and prevent confusion. The field is used for debugging purposes to limit the maximum number of iterations during minification.
Key changes:
- Renamed field from
passestomax_iterationsin the CompressOptions struct - Updated the corresponding field mapping in the TryFrom implementation
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Merge activity
|
`max_iterations` does not behave like `passes`, and may change in the future. It should only be used for debugging purposes, as said on the comment.
graphite-app
bot
force-pushed
the
10-15-fix_napi_minify_s_passes_max_iterations_to_avoid_confusion
branch
from
55514f9 to
32a41cf
Compare
graphite-app
bot
deleted the
10-15-fix_napi_minify_s_passes_max_iterations_to_avoid_confusion
branch
max_iterationsdoes not behave likepasses, and may change in the future.It should only be used for debugging purposes, as said on the
comment.