feat(transformer_plugins): add changed field to ReplaceGlobalDefinesReturn #14617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a changed field to ReplaceGlobalDefinesReturn to track whether the AST was modified during the global defines replacement transformation, eliminating the need for AST comparison to detect changes.
Key Changes
- Added
changed: boolfield toReplaceGlobalDefinesReturnstruct with tracking logic - Implemented
mark_as_changed()helper method called when replacements occur - Added test assertion to validate the
changedfield accuracy
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/oxc_transformer_plugins/src/replace_global_defines.rs | Adds changed field to struct and return type, implements tracking via mark_as_changed() method |
| crates/oxc_transformer_plugins/tests/integrations/replace_global_defines.rs | Adds assertion to verify changed field correctness and updates test cases to use transforming replacements |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Member
Author
Merge activity
|
…eturn (#14617) ## Summary Add a `changed: bool` field to `ReplaceGlobalDefinesReturn` to track whether the AST was modified during the global defines replacement transformation. - Adds `changed` field to `ReplaceGlobalDefinesReturn` struct - Tracks changes via consolidated `mark_as_changed()` helper method - Updates both expression and assignment expression traversal methods - Adds test assertion to verify correctness of the `changed` field This allows callers to efficiently determine if replacements were made without needing to compare the AST before and after transformation. ## Test plan - [x] All existing tests pass - [x] Added assertion in test helper to verify `changed` field matches expected behavior (`source_text != expected`) 🤖 Generated with [Claude Code](https://claude.com/claude-code)
graphite-app
bot
force-pushed
the
feat/replace-global-defines-changed-field
branch
from
dd1a873 to
a81267e
Compare
graphite-app
bot
deleted the
feat/replace-global-defines-changed-field
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a
changed: boolfield toReplaceGlobalDefinesReturnto track whether the AST was modified during the global defines replacement transformation.changedfield toReplaceGlobalDefinesReturnstructmark_as_changed()helper methodchangedfieldThis allows callers to efficiently determine if replacements were made without needing to compare the AST before and after transformation.
Test plan
changedfield matches expected behavior (source_text != expected)🤖 Generated with Claude Code