Skip to content

Conversation

@camchenry
Copy link
Member

@camchenry camchenry commented Oct 15, 2025

Simple refactor to make the code style here a bit more consistent with other lint rules and also take advantage of the linter codegen analysis.

+1% perf on the radix UI benchmark.

@github-actions github-actions bot added A-linter Area - Linter C-performance Category - Solution not expected to change functional behavior, only performance labels Oct 15, 2025
Copy link
Member Author

camchenry commented Oct 15, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 15, 2025

CodSpeed Performance Report

Merging #14630 will not alter performance

Comparing 10-15-perf_linter_update_react_prefer-es6-class_to_use_top-level_match (82196e7) with main (9cd7a67)1

Summary

✅ 4 untouched
⏩ 33 skipped2

Footnotes

  1. No successful run was found on main (82196e7) during the generation of this report, so 9cd7a67 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 33 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@camchenry camchenry marked this pull request as ready for review October 15, 2025 15:25
@camchenry camchenry requested a review from camc314 as a code owner October 15, 2025 15:25
Copilot AI review requested due to automatic review settings October 15, 2025 15:25
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Refactors the rule logic to use a top-level match for consistency and potential codegen performance benefits.

  • Replaces nested if/let destructuring with match arms with guards.
  • Consolidates branching for CallExpression and Class handling into a single match statement.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@camc314 camc314 self-assigned this Oct 15, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 15, 2025

Merge activity

…14630)

Simple refactor to make the code style here a bit more consistent with other lint rules and also take advantage of the linter codegen analysis.

+1% perf on the radix UI benchmark.
@graphite-app graphite-app bot force-pushed the 10-15-perf_linter_update_react_prefer-es6-class_to_use_top-level_match branch from 450e22f to 82196e7 Compare October 15, 2025 20:51
@graphite-app graphite-app bot merged commit 82196e7 into main Oct 15, 2025
20 checks passed
@graphite-app graphite-app bot deleted the 10-15-perf_linter_update_react_prefer-es6-class_to_use_top-level_match branch October 15, 2025 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-performance Category - Solution not expected to change functional behavior, only performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants