fix(semantic): add condition basic blocks to CFG for logical expressions

[camc314]

Add explicit condition basic blocks in the control flow graph for logical
expressions and logical assignment operators. This improves CFG accuracy by
representing condition evaluation as distinct nodes.

Changes:

• Create condition basic blocks before evaluating left operands of logical expressions (&&, ||, ??)
• Record and attach AST nodes to condition blocks for better traceability
• Add edges from preceding blocks to condition blocks
• Apply same treatment to logical assignment operators (&&=, ||=, ??=)

This affects CFG generation for:

• LogicalExpression nodes
• AssignmentExpression nodes with logical operators

[camc314]

• fix(semantic): add condition basic blocks to CFG for logical expressions #14671 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Performance Report

Merging #14671 will not alter performance

_{Comparing c/10-16-fix_semantic_add_condition_basic_blocks_to_cfg_for_logical_expressions (2ce7edd) with main (d161729)}

Summary

✅ 37 untouched

[Copilot]

Pull Request Overview

This PR enhances the control flow graph (CFG) generation for logical expressions by adding explicit condition basic blocks. Previously, logical expressions (&&, ||, ??) and their assignment operator equivalents (&&=, ||=, ??=) lacked distinct condition nodes in the CFG, which reduced traceability and accuracy.

Key changes:

• Added condition basic blocks before evaluating left operands of logical expressions
• Extended the same treatment to logical assignment operators
• Updated CFG snapshots to reflect the new basic block structure

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

File	Description
crates/oxc_semantic/src/builder.rs	Core implementation adding condition block creation and edge connections for logical expressions and assignments
crates/oxc_semantic/tests/integration/snapshots/*.snap	Updated test snapshots reflecting additional basic blocks and edges in CFG output

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[camc314]

Merge activity

• Oct 17, 10:25 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Oct 17, 10:25 AM UTC: camc314 added this pull request to the Graphite merge queue.
• Oct 17, 10:52 AM UTC: Merged by the Graphite merge queue.