Skip to content

Conversation

@connorshea
Copy link
Contributor

Was using the wrong headers for the page structure: https://oxc.rs/docs/guide/usage/linter/rules/eslint/max-params.html#options

Was using the wrong headers for the page structure.

Signed-off-by: Connor Shea <connor.james.shea@gmail.com>
@connorshea connorshea requested a review from camc314 as a code owner October 18, 2025 06:41
Copilot AI review requested due to automatic review settings October 18, 2025 06:41
@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 18, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adjusts documentation headings in the max_params rule to align with the docs page structure.

  • Change option headings from H3 to H4 under the "Options" section
  • No behavioral or code logic changes; documentation-only update

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions github-actions bot added the A-linter Area - Linter label Oct 18, 2025
@connorshea connorshea changed the title Fix documentation formatting for max_params options docs(linter): fix documentation formatting for max_params options Oct 18, 2025
@github-actions github-actions bot added the C-docs Category - Documentation. Related to user-facing or internal documentation label Oct 18, 2025
@camc314 camc314 self-assigned this Oct 22, 2025
Copy link
Contributor

@camc314 camc314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 22, 2025

CodSpeed Performance Report

Merging #14744 will not alter performance

Comparing connorshea:patch-1 (6964b59) with main (4283fd8)

Summary

✅ 4 untouched
⏩ 33 skipped1

Footnotes

  1. 33 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@camc314 camc314 merged commit 9cd4160 into oxc-project:main Oct 22, 2025
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-docs Category - Documentation. Related to user-facing or internal documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants