perf(linter/plugins): speed up SourceCode#getAncestors
#14747
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
the
C-performance
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes the getAncestors function in the SourceCode plugin by refactoring the loop structure for better performance. The changes simplify the code by eliminating a temporary variable and improving the loop termination condition.
- Replaced for-loop with while-loop to remove temporary
ancestorvariable - Changed loop termination from truthiness check to explicit
=== nullcomparison - Reduced code repetition by consolidating parent access logic
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Member
Author
Merge activity
|
graphite-app bot
pushed a commit
that referenced
this pull request
Oct 18, 2025
Optimize `SourceCode#getAncestors`: * Remove temp var `ancestor`. * Reduce code repetition. * Check for end of loop with `=== null` (instead of truthiness test).
graphite-app
bot
force-pushed
the
10-18-perf_linter_plugins_speed_up_sourcecode_getancestors_
branch
from
90ab539 to
cdd9b1b
Compare
overlookmotel
force-pushed
the
10-18-perf_linter_plugins_speed_up_sourcecode_getancestors_
branch
from
cdd9b1b to
93e9ef6
Compare
Optimize `SourceCode#getAncestors`: * Remove temp var `ancestor`. * Reduce code repetition. * Check for end of loop with `=== null` (instead of truthiness test).
graphite-app
bot
force-pushed
the
10-18-perf_linter_plugins_speed_up_sourcecode_getancestors_
branch
from
93e9ef6 to
e6f351d
Compare
graphite-app
bot
deleted the
10-18-perf_linter_plugins_speed_up_sourcecode_getancestors_
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize
SourceCode#getAncestors:ancestor.=== null(instead of truthiness test).