Skip to content

refactor(linter/plugins): update outdated comment #14750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 18, 2025
Merged

refactor(linter/plugins): update outdated comment #14750

merged 1 commit into from
Oct 18, 2025

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Oct 18, 2025 •
edited
Loading

We forgot to update this comment in #14637.

@github-actions github-actions bot added A-linter Area - Linter A-cli Area - CLI C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Oct 18, 2025
@overlookmotel Graphite App
Copy link
Member Author

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review October 18, 2025 11:21
Copilot AI review requested due to automatic review settings October 18, 2025 11:21
Copilot AI reviewed Oct 18, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates an outdated comment in the source code plugin to reflect the current implementation. The comment previously indicated that string deserialization was expensive and should be made lazy, but this has apparently been implemented since then.

Key Changes

  • Updated a TODO comment to accurately describe the current lazy deserialization implementation

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@overlookmotel overlookmotel self-assigned this Oct 18, 2025
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Oct 18, 2025
@overlookmotel Graphite App
Copy link
Member Author

overlookmotel commented Oct 18, 2025 •
edited by graphite-app bot
Loading

Merge activity

@graphite-app graphite-app bot force-pushed the 10-18-refactor_linter_plugins_update_outdated_comment branch from e6d8f9f to e9c3b18 Compare October 18, 2025 11:24
@graphite-app graphite-app bot merged commit e9c3b18 into main Oct 18, 2025
18 checks passed
@graphite-app graphite-app bot deleted the 10-18-refactor_linter_plugins_update_outdated_comment branch October 18, 2025 11:29
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 18, 2025
@Boshen Boshen mentioned this pull request Oct 22, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@camc314 camc314 camc314 approved these changes

Assignees

@overlookmotel overlookmotel

Labels

A-cli Area - CLI A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@overlookmotel @camc314