refactor(linter/plugins): move token-related SourceCode methods into separate file
#14770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-linter
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Pull Request Overview
Refactor to extract token-related SourceCode methods into a dedicated module, reducing clutter in source_code.ts while preserving behavior.
- Extracted token-related methods and related option types into plugins/tokens.ts
- Delegated SourceCode token methods to the new tokens module
- Updated public type exports to come from plugins/tokens.ts
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 8 comments.
| File | Description |
|---|---|
| apps/oxlint/src-js/plugins/tokens.ts | New module housing token-related SourceCode methods and option/type definitions. |
| apps/oxlint/src-js/plugins/source_code.ts | Replaces inline token methods with delegations to tokens module; removes now-moved type definitions. |
| apps/oxlint/src-js/index.ts | Re-exports token-related option types from tokens.ts instead of source_code.ts. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Merge activity
|
…o separate file (#14770) Pure refactor. Move methods of `SourceCode` related to tokens into a separate file, to make main `source_code.js` file less crowded.
graphite-app
bot
force-pushed
the
10-19-refactor_linter_plugins_move_token-related_sourcecode_methods_into_separate_file
branch
from
3781b22 to
cd068aa
Compare
graphite-app
bot
deleted the
10-19-refactor_linter_plugins_move_token-related_sourcecode_methods_into_separate_file
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pure refactor. Move methods of
SourceCoderelated to tokens into a separate file, to make mainsource_code.jsfile less crowded.