Skip to content

Conversation

@connorshea
Copy link
Contributor

@connorshea connorshea commented Oct 19, 2025

Previously this wasn't following the same format as most other rules with options, now it is.

Related to #14743

I tried converting this to auto-gen docs, but I have no idea how to get that working without the compiler complaining, honestly.

… rule.

Previously this wasn't following the same format as most other rules
with options, now it is.
Copilot AI review requested due to automatic review settings October 19, 2025 22:29
@connorshea connorshea requested a review from camc314 as a code owner October 19, 2025 22:29
@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 19, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-linter Area - Linter C-docs Category - Documentation. Related to user-facing or internal documentation labels Oct 19, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Align the no-empty-function rule documentation with the standard “Options” format used by other rules, improving clarity and consistency.

  • Replaces “Configuration” with structured “Options” section and an “allow” subsection including type/default.
  • Updates the example to show a focused rule configuration snippet.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Connor Shea <connor.james.shea@gmail.com>
@camc314 camc314 self-assigned this Oct 20, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 21, 2025

CodSpeed Performance Report

Merging #14789 will not alter performance

Comparing connorshea:cshea/no-empty-function-options (472230d) with main (a64180e)

Summary

✅ 4 untouched
⏩ 33 skipped1

Footnotes

  1. 33 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Copy link
Contributor

@camc314 camc314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@camc314 camc314 merged commit 983c31c into oxc-project:main Oct 21, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-docs Category - Documentation. Related to user-facing or internal documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants