Skip to content

Conversation

@shulaoda
Copy link
Member

No description provided.

Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the A-linter Area - Linter label Oct 20, 2025
@shulaoda shulaoda changed the title refactor(linter/no-unwanted-polyfillio): move NEXT_POLYFILLED_FEATURES to shared utils refactor(linter/no-unwanted-polyfillio): move `` to shared utils Oct 20, 2025
@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Oct 20, 2025
@shulaoda shulaoda changed the title refactor(linter/no-unwanted-polyfillio): move `` to shared utils refactor(linter/no-unwanted-polyfillio): move NEXT_POLYFILLED_FEATURES to shared utils Oct 20, 2025
@shulaoda shulaoda marked this pull request as ready for review October 20, 2025 01:54
@shulaoda shulaoda requested a review from camc314 as a code owner October 20, 2025 01:54
Copilot AI review requested due to automatic review settings October 20, 2025 01:54
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Refactors the NEXT_POLYFILLED_FEATURES constant by moving it from the specific linter rule to a shared utils module to improve code organization and reusability.

  • Moved NEXT_POLYFILLED_FEATURES constant from rule-specific file to shared nextjs utils
  • Updated import statement to reference the constant from the new location
  • Maintained all original functionality while improving code structure

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
crates/oxc_linter/src/utils/nextjs.rs Added the NEXT_POLYFILLED_FEATURES constant to shared utils
crates/oxc_linter/src/rules/nextjs/no_unwanted_polyfillio.rs Removed the constant definition and updated import to use shared version

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 20, 2025

CodSpeed Performance Report

Merging #14793 will not alter performance

Comparing 10-20-refactor_linter_no-unwanted-polyfillio_move_next_polyfilled_features_to_shared_utils (a5bc529) with main (d39bed0)1

Summary

✅ 4 untouched
⏩ 33 skipped2

Footnotes

  1. No successful run was found on main (ef02760) during the generation of this report, so d39bed0 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 33 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Oct 20, 2025
Copy link
Contributor

camc314 commented Oct 20, 2025

Merge activity

graphite-app bot pushed a commit that referenced this pull request Oct 20, 2025
@graphite-app graphite-app bot force-pushed the 10-20-refactor_linter_no-unwanted-polyfillio_move_next_polyfilled_features_to_shared_utils branch from a5bc529 to acb3f2a Compare October 20, 2025 08:08
@graphite-app graphite-app bot force-pushed the 10-20-refactor_linter_no-unwanted-polyfillio_move_next_polyfilled_features_to_shared_utils branch from acb3f2a to 1e93ceb Compare October 20, 2025 08:13
@graphite-app graphite-app bot merged commit 1e93ceb into main Oct 20, 2025
20 checks passed
@graphite-app graphite-app bot deleted the 10-20-refactor_linter_no-unwanted-polyfillio_move_next_polyfilled_features_to_shared_utils branch October 20, 2025 08:17
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 20, 2025
@camc314 camc314 self-assigned this Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants