Skip to content

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Oct 20, 2025

fixes #13010

@camc314 camc314 marked this pull request as ready for review October 20, 2025 10:20
Copilot AI review requested due to automatic review settings October 20, 2025 10:20
@github-actions github-actions bot added A-linter Area - Linter C-bug Category - Bug labels Oct 20, 2025
Copy link
Contributor Author

camc314 commented Oct 20, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camc314 camc314 self-assigned this Oct 20, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes issue #13010 by improving the handling of non-static method properties in the no-invalid-fetch-options linter rule. When a method name cannot be resolved (e.g., when it references an external variable), the rule now marks it as unknown rather than continuing with potentially incorrect analysis.

Key Changes:

  • Added fallback behavior to set method_name to UNKNOWN_METHOD_NAME when a symbol cannot be resolved
  • Added test case covering the scenario where method options are passed as variables

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 20, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the c/10-20-fix_linter_no-invalid-fetch-options_ignore_non_static_method branch from 7faaf8e to dc03c3a Compare October 20, 2025 10:24
@graphite-app graphite-app bot merged commit dc03c3a into main Oct 20, 2025
20 checks passed
@graphite-app graphite-app bot deleted the c/10-20-fix_linter_no-invalid-fetch-options_ignore_non_static_method branch October 20, 2025 10:28
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 20, 2025

CodSpeed Performance Report

Merging #14806 will not alter performance

Comparing c/10-20-fix_linter_no-invalid-fetch-options_ignore_non_static_method (dc03c3a) with main (8b02074)1

Summary

✅ 4 untouched
⏩ 33 skipped2

Footnotes

  1. No successful run was found on main (dc03c3a) during the generation of this report, so 8b02074 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 33 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

linter: no-invalid-fetch-options should ignore non static method

2 participants