fix(cfg): append switch case condition to correct block #14810
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Performance ReportMerging #14810 will not alter performanceComparing Summary
|
graphite-app
bot
changed the base branch from
c/10-20-fix_semantic_cfg_update_example_docs_code
to
graphite-base/14810
Merge activity
|
When a switch case test contains a logical expression (|| or &&), visiting the expression creates multiple CFG blocks for short-circuit evaluation and changes current_node_ix. The condition instruction must be appended to the block BEFORE visiting the expression, not after. This matches the pattern used in visit_if_statement and ensures the condition instruction is placed in the case entry block, making it discoverable by code that identifies case test blocks. Before: ```rust self.visit_expression(expr); // moves current_node_ix cfg.append_condition_to(cfg.current_node_ix, ...); // wrong block After: let condition_block_ix = cfg.current_node_ix; // save before self.visit_expression(expr); cfg.append_condition_to(condition_block_ix, ...); // correct block
graphite-app
bot
force-pushed
the
c/10-20-fix_cfg_append_switch_case_condition_to_correct_block
branch
from
fa8658e to
7e888d2
Compare
graphite-app
bot
deleted the
c/10-20-fix_cfg_append_switch_case_condition_to_correct_block
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a switch case test contains a logical expression (|| or &&), visiting the expression creates multiple CFG blocks for short-circuit evaluation and changes current_node_ix. The condition instruction must be appended to the block BEFORE visiting the expression, not after.
This matches the pattern used in visit_if_statement and ensures the condition instruction is placed in the case entry block, making it discoverable by code that identifies case test blocks.
Before:
After: